From: Jason Gunthorpe <jgg@ziepe.ca>
To: Peter Xu <peterx@redhat.com>, dan.j.williams@intel.com
Cc: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/2] KVM: do not assume PTE is writable after follow_pfn
Date: Mon, 8 Feb 2021 14:51:33 -0400 [thread overview]
Message-ID: <20210208185133.GW4718@ziepe.ca> (raw)
In-Reply-To: <20210205181411.GB3195@xz-x1>
On Fri, Feb 05, 2021 at 01:14:11PM -0500, Peter Xu wrote:
> But I do have a question on why dax as the only user needs to pass in the
> notifier to follow_pte() for initialization.
Not sure either, why does DAX opencode something very much like
page_mkclean() with dax_entry_mkclean()?
Also it looks like DAX uses the wrong notifier, it calls
MMU_NOTIFY_CLEAR but page_mkclean_one() uses
MMU_NOTIFY_PROTECTION_PAGE for the same PTE modification sequence??
page_mkclean() has some technique to make the notifier have the right
size without becoming entangled in the PTL locks..
Jason
next prev parent reply other threads:[~2021-02-08 18:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 10:32 [PATCH 0/2] KVM: do not assume PTE is writable after follow_pfn Paolo Bonzini
2021-02-05 10:32 ` [PATCH 1/2] mm: provide a sane PTE walking API for modules Paolo Bonzini
2021-02-05 13:49 ` Jason Gunthorpe
2021-02-08 17:39 ` Christoph Hellwig
2021-02-08 18:18 ` Paolo Bonzini
2021-02-09 8:14 ` Christoph Hellwig
2021-02-09 9:19 ` Paolo Bonzini
2021-02-05 10:32 ` [PATCH 2/2] KVM: do not assume PTE is writable after follow_pfn Paolo Bonzini
2021-02-05 15:43 ` kernel test robot
2021-02-05 17:41 ` kernel test robot
2021-02-05 18:14 ` [PATCH 0/2] " Peter Xu
2021-02-08 18:51 ` Jason Gunthorpe [this message]
2021-02-08 22:02 ` Peter Xu
2021-02-08 23:26 ` Jason Gunthorpe
2021-02-09 0:23 ` Peter Xu
2021-02-09 8:19 ` Christoph Hellwig
2021-02-09 10:02 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208185133.GW4718@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).