From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49701C433E0 for ; Mon, 8 Feb 2021 22:03:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C735064E66 for ; Mon, 8 Feb 2021 22:03:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C735064E66 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E5876B0005; Mon, 8 Feb 2021 17:03:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1950F6B006C; Mon, 8 Feb 2021 17:03:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A8B76B006E; Mon, 8 Feb 2021 17:03:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id E42586B0005 for ; Mon, 8 Feb 2021 17:03:07 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 945FFD200 for ; Mon, 8 Feb 2021 22:03:07 +0000 (UTC) X-FDA: 77796476814.30.plate46_570c84527602 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 6D340181A17B9 for ; Mon, 8 Feb 2021 22:03:07 +0000 (UTC) X-HE-Tag: plate46_570c84527602 X-Filterd-Recvd-Size: 4478 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 22:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612821786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lTX0pF9nf8RNJQU7qZz8qZTgTzfq7MWAZYxVYVxWqa8=; b=bY3sFMy3NOaD6WNQ4AzVLfSgaiTMS0yCqGKyor08in4jZb8fF5bFmCbaCacJd1CVefPovE mr+s/DMqsLRk7U9rJZjrUNXoFOpdwqB3LCR/kI9Fk1bF2uSmcbzuxIRWzrp5arkbbN2Qo8 rTNM3VWaLrKe41hUMiGwZNR64AP5f2Q= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-106-qVednZwOOPqb0a_txtlueQ-1; Mon, 08 Feb 2021 17:03:04 -0500 X-MC-Unique: qVednZwOOPqb0a_txtlueQ-1 Received: by mail-qt1-f200.google.com with SMTP id k17so2876161qtm.13 for ; Mon, 08 Feb 2021 14:03:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lTX0pF9nf8RNJQU7qZz8qZTgTzfq7MWAZYxVYVxWqa8=; b=UbnGM7lrRR4JdPpogb2YGWLVoqUZ5A/JWfk4WWJdB0OhN6tVzt/ipjCazEJqa6fuA4 rLeGjYRToKLvJsfkLVXCHmpYaAlHBFzwkRpAJxPlSxK29+hVjbuFG55QQw6GhHmrHsYy ZJeQLYxGjWeLeuAgG5225WM6Es7f1n7rpq8JiRA1r7/jr4SBm2IZKFeQL+So1AWIbKSU iFpBvcLkEtipZVIh4Zplgu2zpFVimmR8Hn/PnZp2dqCUgBlh/QE4DOw/8LOMKqoquHdX XPLAaI+EnJuPQFXBi+M5wiU9aeUxiUsg8buuBBBYlge6YVAZ6TCe/ETLru6GeDqpV8VR F8Sw== X-Gm-Message-State: AOAM532QyGLFW6oHfohBHUn4o1A/Ija5YNcq8FGBLcVQB7gSIQLRDCX0 zei0HjGkUN8VqhxHeakat5fqeC8lWRr4WPq51gJi5JGs/qQItbVV03FixQTv/HBlp9Jmb8d7vI/ sXx3O6JsN0pc= X-Received: by 2002:ac8:1283:: with SMTP id y3mr16782055qti.328.1612821783543; Mon, 08 Feb 2021 14:03:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxcP//hjTyuOLVPNFX+cbxbejOsxicI0aDwcP+30/uSNwdFb2okin6reP+9lxD9CelvjcyuBg== X-Received: by 2002:ac8:1283:: with SMTP id y3mr16781975qti.328.1612821782460; Mon, 08 Feb 2021 14:03:02 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-182.dsl.bell.ca. [174.93.89.182]) by smtp.gmail.com with ESMTPSA id 199sm18235920qkm.126.2021.02.08.14.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 14:03:01 -0800 (PST) Date: Mon, 8 Feb 2021 17:02:59 -0500 From: Peter Xu To: Jason Gunthorpe Cc: dan.j.williams@intel.com, Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH 0/2] KVM: do not assume PTE is writable after follow_pfn Message-ID: <20210208220259.GA71523@xz-x1> References: <20210205103259.42866-1-pbonzini@redhat.com> <20210205181411.GB3195@xz-x1> <20210208185133.GW4718@ziepe.ca> MIME-Version: 1.0 In-Reply-To: <20210208185133.GW4718@ziepe.ca> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 08, 2021 at 02:51:33PM -0400, Jason Gunthorpe wrote: > On Fri, Feb 05, 2021 at 01:14:11PM -0500, Peter Xu wrote: > > > But I do have a question on why dax as the only user needs to pass in the > > notifier to follow_pte() for initialization. > > Not sure either, why does DAX opencode something very much like > page_mkclean() with dax_entry_mkclean()? > > Also it looks like DAX uses the wrong notifier, it calls > MMU_NOTIFY_CLEAR but page_mkclean_one() uses > MMU_NOTIFY_PROTECTION_PAGE for the same PTE modification sequence?? > > page_mkclean() has some technique to make the notifier have the right > size without becoming entangled in the PTL locks.. Right. I guess it's because dax doesn't have "struct page*" on the back, so it can't directly use page_mkclean(). However the whole logic does look very similar, so maybe they can be merged in some way. Thanks, -- Peter Xu