From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81B7AC433E0 for ; Wed, 10 Feb 2021 14:27:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26E0B64E0B for ; Wed, 10 Feb 2021 14:27:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26E0B64E0B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B07C6B006E; Wed, 10 Feb 2021 09:27:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70FFE6B0071; Wed, 10 Feb 2021 09:27:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6263D6B0072; Wed, 10 Feb 2021 09:27:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 483AB6B006E for ; Wed, 10 Feb 2021 09:27:50 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0DE3F1AB65 for ; Wed, 10 Feb 2021 14:27:50 +0000 (UTC) X-FDA: 77802587100.25.end51_25026ee27610 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id CA7C8186A4006 for ; Wed, 10 Feb 2021 14:27:49 +0000 (UTC) X-HE-Tag: end51_25026ee27610 X-Filterd-Recvd-Size: 1735 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Feb 2021 14:27:49 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 20294B0D1; Wed, 10 Feb 2021 14:27:48 +0000 (UTC) Date: Wed, 10 Feb 2021 15:27:45 +0100 From: Oscar Salvador To: Vlastimil Babka Cc: David Hildenbrand , Minchan Kim , Andrew Morton , linux-mm , LKML , Michal Hocko Subject: Re: [PATCH] mm: remove lru_add_drain_all in alloc_contig_range Message-ID: <20210210142745.GD3636@localhost.localdomain> References: <20210209175048.361638-1-minchan@kernel.org> <20210209190332.GA3363@localhost.localdomain> <49491777-6d61-db4d-5e90-7a8b9045faca@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49491777-6d61-db4d-5e90-7a8b9045faca@suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 10, 2021 at 01:17:33PM +0100, Vlastimil Babka wrote: > AFAICS, at the time page migration used putback_lru_page() to release the > migration source page. This would put the page on lru pvec even if it was in > fact not mapped anywhere anymore, and only the drain would actually free it. > Seems Minchan optimized this in 2016 by c6c919eb90e0 ("mm: use put_page() to > free page instead of putback_lru_page()") Ok, I see. Thanks for this valuable information Vlastimil. -- Oscar Salvador SUSE L3