From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5BDFC433E0 for ; Mon, 22 Feb 2021 10:24:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 258E36024A for ; Mon, 22 Feb 2021 10:24:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 258E36024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 67CEE6B007B; Mon, 22 Feb 2021 05:24:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6076F8D0001; Mon, 22 Feb 2021 05:24:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CE466B0081; Mon, 22 Feb 2021 05:24:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id 33AA06B007B for ; Mon, 22 Feb 2021 05:24:19 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D96E11801ABC2 for ; Mon, 22 Feb 2021 10:24:18 +0000 (UTC) X-FDA: 77845518996.24.5F44298 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf09.hostedemail.com (Postfix) with ESMTP id E90B660024A1 for ; Mon, 22 Feb 2021 10:24:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 09BB564E2F; Mon, 22 Feb 2021 10:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613989457; bh=hPfUfFtTmjkrQbsktsKt6yfqMzt3/NRJ4jjF/NEBc8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b3V9NfUxwhwIYN04tZ4xVJ3p5sqw8LDNui76vseSDtV/Re6690BnkfF+nR9DcxpOG pUgE90vqEFMU/X/MPAhMaZnhkphLp2hZD3Ly/S74TC7UD+nyJ2MxvQgUFzQn0n4cWr O38zmX3c++0vqSgjip+sme4YMMtTL5UAgX7/Dvrcr8EOMRxrQU75JWaHMRk39qP/AW lgAw/KQkfggAeoHx3YM+5n3m6vnlhaY/3Jp3VStjpjmNap+nGK6+o3g9qwoOyHxtFy vWZY83MCClCfU5xmCjWJ66fOJT92kzAT9sZgszmOAF/eGW/eyThqm6caGmwW8QA7LL 32a3PdFZcp9HQ== Date: Mon, 22 Feb 2021 12:23:59 +0200 From: Mike Rapoport To: Matthew Garrett Cc: Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Matthew Wilcox , Mark Rutland , Michal Hocko , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Rick Edgecombe , Roman Gushchin , Shakeel Butt , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org, Hagen Paul Pfeifer , Palmer Dabbelt Subject: Re: [PATCH v17 08/10] PM: hibernate: disable when there are active secretmem users Message-ID: <20210222102359.GE1447004@kernel.org> References: <20210208084920.2884-1-rppt@kernel.org> <20210208084920.2884-9-rppt@kernel.org> <20210222073452.GA30403@codon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210222073452.GA30403@codon.org.uk> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E90B660024A1 X-Stat-Signature: q7anjicn9o1c5ikk9x8mg97zue9ympd5 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613989454-16929 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 22, 2021 at 07:34:52AM +0000, Matthew Garrett wrote: > On Mon, Feb 08, 2021 at 10:49:18AM +0200, Mike Rapoport wrote: > > > It is unsafe to allow saving of secretmem areas to the hibernation > > snapshot as they would be visible after the resume and this essentially > > will defeat the purpose of secret memory mappings. > > Sorry for being a bit late to this - from the point of view of running > processes (and even the kernel once resume is complete), hibernation is > effectively equivalent to suspend to RAM. Why do they need to be handled > differently here? Hibernation leaves a copy of the data on the disk which we want to prevent. -- Sincerely yours, Mike.