From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF806C433DB for ; Wed, 24 Feb 2021 14:13:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4395964EDB for ; Wed, 24 Feb 2021 14:13:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4395964EDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8564F6B0006; Wed, 24 Feb 2021 09:13:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8072D6B006C; Wed, 24 Feb 2021 09:13:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71CFD6B006E; Wed, 24 Feb 2021 09:13:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 5CD446B0006 for ; Wed, 24 Feb 2021 09:13:21 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1772D6D70 for ; Wed, 24 Feb 2021 14:13:21 +0000 (UTC) X-FDA: 77853353802.18.3B86C09 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by imf08.hostedemail.com (Postfix) with ESMTP id 03851801A813 for ; Wed, 24 Feb 2021 14:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FKo27kP6bPoTFaEgNUhT3kOhszGvSDXkiGvKHnLVuc4=; b=v88BLMp8Jlv/IhPa0X6p6VPq/ iKsgGbnhHi3O5dmWqDdE8DnAzITrnXxTLp38at5EWC5cV1s9AkLODNcoVUSMHAtON2JrEP5nxozhx pBW9ThJ+07++O5wqpXsFhDPy36Sf6JIEoxvn3e0rjcWQgA6rYfdGUIgmoWd8icvwNBVlYBXykGaem UCDdMcfOjSlivEo/CA2tXZgMrYjejVsjNOyoxuZnDlpqGDO2RdeQyY3zDWral1voZ404FL4gI4MeF tUmuL2Qfr/Wf8WcgWfTgJJuuu8bKQAjx5eLoWMdpB6wIPybw+oN0+6EW9eIStAcaUhdFVSl7Fgwuz NM9TLTFwQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46656) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEulb-00005z-Dn; Wed, 24 Feb 2021 14:03:51 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lEulX-00042p-Ej; Wed, 24 Feb 2021 14:03:47 +0000 Date: Wed, 24 Feb 2021 14:03:47 +0000 From: Russell King - ARM Linux admin To: Maninder Singh Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, a.sahrawat@samsung.com, Vaneet Narang Subject: Re: [PATCH 1/1] arm: print alloc free paths for address in registers Message-ID: <20210224140347.GS1463@shell.armlinux.org.uk> References: <1614170254-3207-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614170254-3207-1-git-send-email-maninder1.s@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: 8ixi8i9rjk44popa4f5upzmsou3gwoua X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 03851801A813 Received-SPF: none (armlinux.org.uk>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=pandora.armlinux.org.uk; client-ip=78.32.30.218 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614175987-817687 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000042, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 24, 2021 at 06:07:34PM +0530, Maninder Singh wrote: > +bool slab_page_object(unsigned long address, void **object, struct kmem_cache **cache) > +{ > + void *addr = (void *)address; > + struct page *page; > + > + if ((addr >= (void *)PAGE_OFFSET) && > + (addr < high_memory)) { > + page = virt_to_head_page(addr); This check is not sufficient. There can be holes in the page array. You need to use virt_addr_valid() to validate "addr". -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!