From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5D6C433E0 for ; Wed, 24 Feb 2021 16:51:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4CD8864F06 for ; Wed, 24 Feb 2021 16:51:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CD8864F06 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A872E6B0005; Wed, 24 Feb 2021 11:51:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A38BC6B0006; Wed, 24 Feb 2021 11:51:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E106B006C; Wed, 24 Feb 2021 11:51:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id 7BA026B0005 for ; Wed, 24 Feb 2021 11:51:40 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C3FAEB7BE for ; Wed, 24 Feb 2021 16:51:39 +0000 (UTC) X-FDA: 77853752718.26.D4EE2B3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 921DD40B8CC0 for ; Wed, 24 Feb 2021 16:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aoyPJLOINcOzWX3hzDOiZBRt38O6h9dI3clPQSbSKR4=; b=cE7NwaD5byiIKUjfWuWYFkMHE0 W5cSoETaMV4YMaypv48GFoQl9V8BA1KED/CixT3d+mnLjBkJYgODkBbAAjh1/MzKiwUnHKpC04ozN eQIC2JfSuiOP3lo293V/Ra9C/1i6ijViIdpOqX15N/83gRVJ9R44/yCdgxMlR83R3PNuVqyV+XaqG ONah66BwgxifxBaOlW5OYKNaONVnoFU89l6J77oIQvnoYhUZQ6I+ozB2elhKwbIoLEz4pficEJ70E x4HQTGVbSGQuXz/PzIcovJ7jiiBgCFbx8Rv3bZntokWn+XZXowDdAt0TGbVIYYBxYIIx8SiGLrkZn iPcnhcZw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lExNG-009dqU-Ng; Wed, 24 Feb 2021 16:51:12 +0000 Date: Wed, 24 Feb 2021 16:50:54 +0000 From: Matthew Wilcox To: Jens Axboe Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH 1/3] mm: provide filemap_range_needs_writeback() helper Message-ID: <20210224165054.GR2858050@casper.infradead.org> References: <20210224164455.1096727-1-axboe@kernel.dk> <20210224164455.1096727-2-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210224164455.1096727-2-axboe@kernel.dk> X-Stat-Signature: yma7afiy9fcgrz4hecwyor86kcihpdua X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 921DD40B8CC0 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614185490-955362 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 24, 2021 at 09:44:53AM -0700, Jens Axboe wrote: > +++ b/include/linux/fs.h > @@ -2633,6 +2633,8 @@ static inline int filemap_fdatawait(struct address_space *mapping) > > extern bool filemap_range_has_page(struct address_space *, loff_t lstart, > loff_t lend); > +extern bool filemap_range_needs_writeback(struct address_space *, > + loff_t lstart, loff_t lend); > extern int filemap_write_and_wait_range(struct address_space *mapping, > loff_t lstart, loff_t lend); > extern int __filemap_fdatawrite_range(struct address_space *mapping, These prototypes should all be in pagemap.h, not fs.h. I can do a followup patch if you don't want to do it as part of this set. Also we're deprecating the use of 'extern' for prototypes. Reviewed-by: Matthew Wilcox (Oracle)