From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3512FC433E0 for ; Wed, 24 Feb 2021 20:04:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AF95764F30 for ; Wed, 24 Feb 2021 20:04:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF95764F30 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F80F8D0008; Wed, 24 Feb 2021 15:04:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A8926B00A2; Wed, 24 Feb 2021 15:04:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EDD18D0008; Wed, 24 Feb 2021 15:04:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 195AC6B00A1 for ; Wed, 24 Feb 2021 15:04:32 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D789182E0272 for ; Wed, 24 Feb 2021 20:04:31 +0000 (UTC) X-FDA: 77854238742.26.0DD6BAC Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP id 668FE130 for ; Wed, 24 Feb 2021 20:04:31 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3BF1C64F14; Wed, 24 Feb 2021 20:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614197070; bh=GpUPPlkFhzr/eMBBQFJLDCF7K0yl2WxELSQlNxSfFuA=; h=Date:From:To:Subject:In-Reply-To:From; b=nYb66waLHLpFS9yg5VkpYOdoB+sm/HmP+cKOlotu4OFiV1OLyBh4FOT9oP04QPKTC VYDqiT3Kr1xqZEne7IteqjZKTzpjDYKAkCLkRZZwi0XLBz9EtQ5cxhU909Q2x2HpCw gTfZ26v+kzmj7qsK7Rj+p4L3R5+qatVx45XEfx+A= Date: Wed, 24 Feb 2021 12:04:29 -0800 From: Andrew Morton To: ahuang12@lenovo.com, akpm@linux-foundation.org, david@redhat.com, jrdr.linux@gmail.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 076/173] mm/mmap.c: remove unnecessary local variable Message-ID: <20210224200429.srHZRhLS0%akpm@linux-foundation.org> In-Reply-To: <20210224115824.1e289a6895087f10c41dd8d6@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Stat-Signature: 1ob135cfng5neassysk1bsre4ss4ycwd X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 668FE130 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614197071-131120 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Adrian Huang Subject: mm/mmap.c: remove unnecessary local variable The local variable 'retval' is assigned just for once in __do_sys_brk(), and the function returns the value of the local variable right after the assignment. Remove unnecessary assignment and local variable declaration. Link: https://lkml.kernel.org/r/20201222103249.30683-1-adrianhuang0701@gmail.com Signed-off-by: Adrian Huang Acked-by: Souptick Joarder Reviewed-by: David Hildenbrand Signed-off-by: Andrew Morton --- mm/mmap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/mm/mmap.c~mm-mmap-remove-unnecessary-local-variable +++ a/mm/mmap.c @@ -189,7 +189,6 @@ static int do_brk_flags(unsigned long ad struct list_head *uf); SYSCALL_DEFINE1(brk, unsigned long, brk) { - unsigned long retval; unsigned long newbrk, oldbrk, origbrk; struct mm_struct *mm = current->mm; struct vm_area_struct *next; @@ -281,9 +280,8 @@ success: return brk; out: - retval = origbrk; mmap_write_unlock(mm); - return retval; + return origbrk; } static inline unsigned long vma_compute_gap(struct vm_area_struct *vma) _