From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B195C433E0 for ; Wed, 3 Mar 2021 01:30:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7591F64E27 for ; Wed, 3 Mar 2021 01:30:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7591F64E27 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B4A168D0113; Tue, 2 Mar 2021 20:30:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD27C8D00FA; Tue, 2 Mar 2021 20:30:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E3C8D0113; Tue, 2 Mar 2021 20:30:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id 79DCE8D00FA for ; Tue, 2 Mar 2021 20:30:45 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3B1FB8249980 for ; Wed, 3 Mar 2021 01:30:45 +0000 (UTC) X-FDA: 77876833650.07.A4AB85D Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP id D3422407F8F3 for ; Wed, 3 Mar 2021 01:30:42 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 39B1E64E21; Wed, 3 Mar 2021 01:30:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614735040; bh=OF8WUPKSv4QXc/+YPWIqmJarQdHRZfG1pwud0AaXB9s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Px3O4abFVJu9eUSMf9VaWKMuxsy66RLx0Lx7pWv0Sl7yoYE0IZMJtGTGjGpvYtShx kPXTmRk05YMHg9YPfXNuQufBngiDT2dYPdPRZZi4m9ACvuAzniw16o7b6XzfcK8tnC bfBBq6PNazSz7XQPt5GY6rrVQmMCE/eAIF790xUA= Date: Tue, 2 Mar 2021 17:30:39 -0800 From: Andrew Morton To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Kent Overstreet , Christoph Hellwig Subject: Re: [PATCH] mm/filemap: Use filemap_read_page in filemap_fault Message-Id: <20210302173039.4625f403846abd20413f6dad@linux-foundation.org> In-Reply-To: <20210226140011.2883498-1-willy@infradead.org> References: <20210226140011.2883498-1-willy@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: orkb8ft39xztg9mnseuxnjm71bhayqsc X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D3422407F8F3 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614735042-855987 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 26 Feb 2021 14:00:11 +0000 "Matthew Wilcox (Oracle)" wrote: > After splitting generic_file_buffered_read() into smaller parts, it > turns out we can reuse one of the parts in filemap_fault(). This fixes > an oversight -- waiting for the I/O to complete is now interruptible > by a fatal signal. And it saves us a few bytes of text in an unlikely > path. We also handle AOP_TRUNCATED_PAGE which the present code fails to do. Should this be in the changelog? Did we handle AOP_TRUNCATED_PAGE in the pre-splitup code, or is this new?