From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88BBDC433E0 for ; Thu, 4 Mar 2021 04:26:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2053964E89 for ; Thu, 4 Mar 2021 04:26:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2053964E89 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A693B6B0006; Wed, 3 Mar 2021 23:26:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A40366B0007; Wed, 3 Mar 2021 23:26:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BA7E6B0008; Wed, 3 Mar 2021 23:26:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 6EF3C6B0006 for ; Wed, 3 Mar 2021 23:26:23 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 34D6B18092E0B for ; Thu, 4 Mar 2021 04:26:23 +0000 (UTC) X-FDA: 77880905046.07.E60D32D Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf20.hostedemail.com (Postfix) with ESMTP id 53D95D5 for ; Thu, 4 Mar 2021 04:26:21 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id p5so15413120plo.4 for ; Wed, 03 Mar 2021 20:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=saz39NphErLN6qEzH04XuHlAVGZp77aIU1VH6z80Tzk=; b=Z4iudz7Pmo3VFvkA3EmxhLycHE8GJcTuKp6QcrMJPTdtjFOdsUusPNdSsAF0WJ7tgk ZtQwYExcL5TEeIjJjvLqJO4L1DTyfT7+T5ZVt/TpJKNeLjE07hLlERg9da//BPEoZDME WIIOt9yZ4lmMJfm4gMm11gwdEu2WiCsBioo1cbf4OM0rfyhltVSgsJUO3kaMYfnAzTyd KnRRQ5wsWE81nLOf/MysScoy4RQB6uCjWkjpxnxrk6G7WgfsCkK3XZ7WPctUmAs1BDhd +Z+deMeTyBz+R9xT7kbdDG1Sy+CDnNL9o2mySctfM82CBLg9Rp0Boak1vy09t1yUWoa+ loTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=saz39NphErLN6qEzH04XuHlAVGZp77aIU1VH6z80Tzk=; b=obmc0OsqRwf8jkv7BLGbkPRtFH45BvqzOrtkMOAe8ZBrihHwAfof5fKwYtLeFqEZQI e3tGQC8GOE2nNt2oNCNZ+F89rgcN+dlmoRPaG2y+59gGalTc4UuFSTzUpvCy5Bx546/F GnPvMMDt5pqgMAOowpulassKpPuJLMpNqmlNZR3VKMVt7QbkrMAW9tuVj2S3NoC3q4QG ETsMk/0fbB4qIZMZPf5Etnb5FadTtwCJ7xLduzTxYkY07QTerxbArnry6kVtrKoGRi2n LgPq6vBBvIUgFHcM3a//U0QJGLDh7+hAC3HeWPQvZfNlfxgWUCKQDTDXMLftWAjhB9Ds E67w== X-Gm-Message-State: AOAM533eVAY3NGOTyukI6hOosadwZhnLHqYQ9LR5AYoAqk4OjzYDw5um B9zJqma7FnBvyz8f00UEfts= X-Google-Smtp-Source: ABdhPJyLnxLyD+UXIVjZU6qH/FZP1EZUYxl/7aYzM8K1hx8bHoZ7IDGmGnxXuZgh3qZCJmY10X5Enw== X-Received: by 2002:a17:90a:7f84:: with SMTP id m4mr2467688pjl.76.1614831981749; Wed, 03 Mar 2021 20:26:21 -0800 (PST) Received: from localhost (121-45-173-48.tpgi.com.au. [121.45.173.48]) by smtp.gmail.com with ESMTPSA id u66sm28533366pfc.72.2021.03.03.20.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 20:26:20 -0800 (PST) Date: Thu, 4 Mar 2021 15:26:17 +1100 From: Balbir Singh To: Muchun Song , corbet@lwn.net, mike.kravetz@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, rdunlap@infradead.org, oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, almasrymina@google.com, rientjes@google.com, willy@infradead.org, osalvador@suse.de, mhocko@suse.com, song.bao.hua@hisilicon.com, david@redhat.com, naoya.horiguchi@nec.com, joao.m.martins@oracle.com Cc: duanxiongchun@bytedance.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Miaohe Lin Subject: Re: [PATCH v17 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c Message-ID: <20210304042617.GB1223287@balbir-desktop> References: <20210225132130.26451-1-songmuchun@bytedance.com> <20210225132130.26451-2-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: f4bpfog4o4bwwnd5ffqp4w6mawtibmc3 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 53D95D5 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail-pl1-f172.google.com; client-ip=209.85.214.172 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614831981-648585 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 03, 2021 at 01:45:00PM +1100, Singh, Balbir wrote: > On 26/2/21 12:21 am, Muchun Song wrote: > > Move bootmem info registration common API to individual bootmem_info.c. > > And we will use {get,put}_page_bootmem() to initialize the page for the > > vmemmap pages or free the vmemmap pages to buddy in the later patch. > > So move them out of CONFIG_MEMORY_HOTPLUG_SPARSE. This is just code > > movement without any functional change. > > > > Signed-off-by: Muchun Song > > Acked-by: Mike Kravetz > > Reviewed-by: Oscar Salvador > > Reviewed-by: David Hildenbrand > > Reviewed-by: Miaohe Lin > ... > > > diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c > > new file mode 100644 > > index 000000000000..fcab5a3f8cc0 > > --- /dev/null > > +++ b/mm/bootmem_info.c > > @@ -0,0 +1,124 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * linux/mm/bootmem_info.c > > + * > > + * Copyright (C) > > Looks like incomplete > Not that my comment was, I should have said The copyright looks very incomplete Balbir Singh.