From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8CEEC433E0 for ; Sun, 7 Mar 2021 08:19:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EEF6065126 for ; Sun, 7 Mar 2021 08:19:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEF6065126 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2A1B76B005D; Sun, 7 Mar 2021 03:19:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 250DE6B006C; Sun, 7 Mar 2021 03:19:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F23A6B006E; Sun, 7 Mar 2021 03:19:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id E89CB6B005D for ; Sun, 7 Mar 2021 03:19:05 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 95EA28249980 for ; Sun, 7 Mar 2021 08:19:05 +0000 (UTC) X-FDA: 77892377850.10.E42F15C Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf19.hostedemail.com (Postfix) with ESMTP id 564FD90009E9 for ; Sun, 7 Mar 2021 08:19:04 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id nh23-20020a17090b3657b02900c0d5e235a8so1431267pjb.0 for ; Sun, 07 Mar 2021 00:19:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZhmCGFCWE9B1mgJsiqMToPvrYNntF7QZQE78G1v4dD0=; b=KwD9hVfm+FoiQmNP00Fjr9GPA0JjY12vqRZ/3os7bpBo+JIfIdmBe4CJBbDre7myIz dX7vGD06+sbIwpz9FK6FkZGfT4dtyilx5BS9FE0p4PSFEt3iuHNqQCzB3qsVX2FznMgc f5+5mUayzCuKWvp22MFZIyr8Y44umG45q8LIlHHgdU3ZTV4m+yyrfSbSSj0Z+fdv2d/H nCYQ7i68nmZuTLBsqSjFP8bQGq5XjTLTb+OEBGgFw0Ny/Adt1W5RZnQR7AIm4YI/boC3 V08tE+dogYC9cYDsaGauZGitU4JG2bZwf0Dff9hYmK5b2QwEZ3RDD/mLb9Hh94m4Lr7s sGug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZhmCGFCWE9B1mgJsiqMToPvrYNntF7QZQE78G1v4dD0=; b=m3k+SLZ8b6RCYaf7930Ep44D32qfVS2gnH4TovJfUE8l8qlHFDb0j+qD7zqZL+zLAn oT+a1S1U4OjgY+WKVov3hlBvUxKXzySPNJHMzp+kg3e/H2W5i6hKEMiIv4U3xHC7ITgT e6kLQiSX3cXGrFEn3ULabJu3LiNH6rh5Xuanqc4qUtJ03KetQk0XQcjEyXYCArxUYRGz IDx2ZvpZZWSxHQU6w8kx+2PkD/XKfOd0gAmemdtZKYWIzGKAvUzmS4vpNdaMyZ2ViEz/ DQldn0Oyc9//fyOz8D3M2/V4YZQZ+SZ2s7szN8ehSks3fy53EA/t8CSWZa1lTxn51Gp9 NYPQ== X-Gm-Message-State: AOAM5334dpV1VPHHfwwFiQelLaDo9xYYtr14TcVv8J+lCVOYjMD/XvE+ uWVeUhOllAmxgi7OhjOQ5ak= X-Google-Smtp-Source: ABdhPJw6L+8rGzr6RiNOOEJzLsGocciaUifoiNri6jiHAbpSW7AUvV3P/qCwIq2V+Vgam893063lRQ== X-Received: by 2002:a17:90b:1213:: with SMTP id gl19mr18783404pjb.55.1615105144148; Sun, 07 Mar 2021 00:19:04 -0800 (PST) Received: from localhost (121-45-173-48.tpgi.com.au. [121.45.173.48]) by smtp.gmail.com with ESMTPSA id 2sm6934784pfi.116.2021.03.07.00.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 00:19:01 -0800 (PST) Date: Sun, 7 Mar 2021 19:18:57 +1100 From: Balbir Singh To: Muchun Song Cc: corbet@lwn.net, mike.kravetz@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, rdunlap@infradead.org, oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, almasrymina@google.com, rientjes@google.com, willy@infradead.org, osalvador@suse.de, mhocko@suse.com, song.bao.hua@hisilicon.com, david@redhat.com, naoya.horiguchi@nec.com, joao.m.martins@oracle.com, duanxiongchun@bytedance.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v17 5/9] mm: hugetlb: set the PageHWPoison to the raw error page Message-ID: <20210307081857.GE1223287@balbir-desktop> References: <20210225132130.26451-1-songmuchun@bytedance.com> <20210225132130.26451-6-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225132130.26451-6-songmuchun@bytedance.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 564FD90009E9 X-Stat-Signature: 43tskhkcwto7zp7u11t7cc31ut3znsrw Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=mail-pj1-f52.google.com; client-ip=209.85.216.52 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615105144-181139 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 25, 2021 at 09:21:26PM +0800, Muchun Song wrote: > Because we reuse the first tail vmemmap page frame and remap it > with read-only, we cannot set the PageHWPosion on some tail pages. > So we can use the head[4].private (There are at least 128 struct > page structures associated with the optimized HugeTLB page, so > using head[4].private is safe) to record the real error page index > and set the raw error page PageHWPoison later. > Does the hardcoding of 4 come from HUGETLB_CGROUP_MIN_ORDER, if so do we need to hardcode 4? Also, I am not sure about the comment on safety and 128 struct pages Balbir