linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] USB: gadget: f_fs: fix memdup_user.cocci warnings
       [not found] <202103081519.ZUP3wXzn-lkp@intel.com>
@ 2021-03-08  7:09 ` kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-03-08  7:09 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: kbuild-all, linux-kernel, Peter Chen, Felipe Balbi, Jens Axboe,
	Andrew Morton, Linux Memory Management List, Gustavo A. R. Silva,
	Lee Jones, Vamsi Krishna Samavedam, Sriharsha Allenki

From: kernel test robot <lkp@intel.com>

drivers/usb/gadget/function/f_fs.c:3829:8-15: WARNING opportunity for memdup_user

 Use memdup_user rather than duplicating its implementation
 This is a little bit restricted to reduce false positives

Generated by: scripts/coccinelle/api/memdup_user.cocci

Fixes: 8704fd73bf56 ("USB: gadget: f_fs: remove likely/unlikely")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   144c79ef33536b4ecb4951e07dbc1f2b7fa99d32
commit: 8704fd73bf5658bf4b827643f7f526481082d83f USB: gadget: f_fs: remove likely/unlikely

 f_fs.c |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

--- a/drivers/usb/gadget/function/f_fs.c
+++ b/drivers/usb/gadget/function/f_fs.c
@@ -3826,14 +3826,9 @@ static char *ffs_prepare_buffer(const ch
 	if (!len)
 		return NULL;
 
-	data = kmalloc(len, GFP_KERNEL);
-	if (!data)
-		return ERR_PTR(-ENOMEM);
-
-	if (copy_from_user(data, buf, len)) {
-		kfree(data);
-		return ERR_PTR(-EFAULT);
-	}
+	data = memdup_user(buf, len);
+	if (IS_ERR(data))
+		return ERR_PTR(PTR_ERR(data));
 
 	pr_vdebug("Buffer from user space:\n");
 	ffs_dump_mem("", data, len);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-08  7:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <202103081519.ZUP3wXzn-lkp@intel.com>
2021-03-08  7:09 ` [PATCH] USB: gadget: f_fs: fix memdup_user.cocci warnings kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).