Re: [PATCH v5 3/4] x86/vmemmap: Handle unpopulated sub-pmd ranges

Oscar Salvador
2021-03-10T21:58:24Z

On Wed, Mar 10, 2021 at 06:58:26PM +0100, David Hildenbrand wrote:
> Thinking again, I guess it might be a good idea to factor out the core
> functions into common code. For the optimization part, it might make sense
> too pass some "state" structure that contains e.g., "unused_pmd_start".

Yeah, that really sounds like a good thing to do.

>
> Then we don't have diverging implementations of essentially the same thing.
>
> Of course, we can do that on top of this series - unifying both
> implementations.

I would rather do it on top of this series, not because I am lazy, but
rather fairly busy and I will not be able to spend much time on it
anytime soon.

Once this series gets merged, I commit to have a look into that.

Thanks!

--
Oscar Salvador
SUSE L3