From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BBE2C433DB for ; Fri, 19 Mar 2021 17:49:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E097C6197B for ; Fri, 19 Mar 2021 17:49:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E097C6197B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C9F96B007B; Fri, 19 Mar 2021 13:49:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67A686B007D; Fri, 19 Mar 2021 13:49:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51AB86B007E; Fri, 19 Mar 2021 13:49:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 31E076B007B for ; Fri, 19 Mar 2021 13:49:38 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DFC14181FE095 for ; Fri, 19 Mar 2021 17:49:37 +0000 (UTC) X-FDA: 77937361194.04.C39C5B9 Received: from outbound-smtp44.blacknight.com (outbound-smtp44.blacknight.com [46.22.136.52]) by imf02.hostedemail.com (Postfix) with ESMTP id 92C664000A4C for ; Fri, 19 Mar 2021 17:49:29 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp44.blacknight.com (Postfix) with ESMTPS id C0530F868E for ; Fri, 19 Mar 2021 17:49:27 +0000 (GMT) Received: (qmail 11366 invoked from network); 19 Mar 2021 17:49:27 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 19 Mar 2021 17:49:27 -0000 Date: Fri, 19 Mar 2021 17:49:26 +0000 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Chuck Lever , Jesper Dangaard Brouer , Christoph Hellwig , Alexander Duyck , Matthew Wilcox , LKML , Linux-Net , Linux-MM , Linux-NFS Subject: Re: [PATCH 1/7] mm/page_alloc: Move gfp_allowed_mask enforcement to prepare_alloc_pages Message-ID: <20210319174926.GC3697@techsingularity.net> References: <20210312154331.32229-1-mgorman@techsingularity.net> <20210312154331.32229-2-mgorman@techsingularity.net> <2b5b3bea-c247-0564-f2d4-1dad28f176ed@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <2b5b3bea-c247-0564-f2d4-1dad28f176ed@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: wnxywpcywydak61fos5j7wn58sbqpway X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 92C664000A4C Received-SPF: none (techsingularity.net>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=outbound-smtp44.blacknight.com; client-ip=46.22.136.52 X-HE-DKIM-Result: none/none X-HE-Tag: 1616176169-177882 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 19, 2021 at 05:11:39PM +0100, Vlastimil Babka wrote: > On 3/12/21 4:43 PM, Mel Gorman wrote: > > __alloc_pages updates GFP flags to enforce what flags are allowed > > during a global context such as booting or suspend. This patch moves the > > enforcement from __alloc_pages to prepare_alloc_pages so the code can be > > shared between the single page allocator and a new bulk page allocator. > > > > When moving, it is obvious that __alloc_pages() and __alloc_pages > > use different names for the same variable. This is an unnecessary > > complication so rename gfp_mask to gfp in prepare_alloc_pages() so the > > name is consistent. > > > > No functional change. > > Hm, I have some doubts. > And you were right, I'll drop the patch and apply the same mask to the bulk allocator. -- Mel Gorman SUSE Labs