From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CEBC433C1 for ; Fri, 19 Mar 2021 18:08:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C1D86194C for ; Fri, 19 Mar 2021 18:08:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C1D86194C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AFAA36B0070; Fri, 19 Mar 2021 14:08:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA9E86B0071; Fri, 19 Mar 2021 14:08:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 974A66B0073; Fri, 19 Mar 2021 14:08:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 7BDA36B0070 for ; Fri, 19 Mar 2021 14:08:14 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3DA681E12 for ; Fri, 19 Mar 2021 18:08:14 +0000 (UTC) X-FDA: 77937408108.20.7126EB6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 26D1FC000C6F for ; Fri, 19 Mar 2021 18:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vHfHyXotbRzGZh7y4q6pGdO4bWDVhUMZBFQ0KkjrwPU=; b=iozU64Xb4N0CWU4tgHMvEiJzgP 5aAVKi3e8aOUxW+gAXhE0xiFIthJysSAFGfZ8UISNOroK6nQrdghBfhcSXUnKI2Wd8604LTnlVluK 5dl/LgSLrAHghhNNRg69cFtchNA1tkl+svPALeAVbq7KNLxl+5gyZByHaj65UpIaL85HgyTLMtpSu JpgjyUt7QTUES17BQRwqxdB3Ytyh/8rFwm1Z9Fp7a0SfwojMaqHnDSr8e5WDckwHzZvALFx+7Wwcu bMe2lMIl/lPVM5aufgHuGcNY0PZeEz4C2PZbAiOVhSCR3C5bP/BN3PCXqWbelIXDf2tArOFI24oBe RlHTiVxw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lNJXF-004nzY-9E; Fri, 19 Mar 2021 18:07:51 +0000 Date: Fri, 19 Mar 2021 18:07:45 +0000 From: Matthew Wilcox To: Dmitry Osipenko Cc: Minchan Kim , Greg Kroah-Hartman , Andrew Morton , linux-mm , LKML , joaodias@google.com, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v4] mm: cma: support sysfs Message-ID: <20210319180745.GB3420@casper.infradead.org> References: <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> <82bde114-60c0-3fde-43f4-844522b80673@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82bde114-60c0-3fde-43f4-844522b80673@gmail.com> X-Stat-Signature: w3868p59iyi7m9ob7pnjtqm4n4s94akt X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 26D1FC000C6F Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616177286-758202 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 19, 2021 at 08:29:29PM +0300, Dmitry Osipenko wrote: > > +static ssize_t alloc_pages_success_show(struct kobject *kobj, > > + struct kobj_attribute *attr, char *buf) > > The indentations are still wrong. > > CHECK: Alignment should match open parenthesis > #321: FILE: mm/cma_sysfs.c:28: > +static ssize_t alloc_pages_success_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) This is bullshit. Do not waste people's time with this frivolity.