From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 957C6C43460 for ; Tue, 6 Apr 2021 13:36:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 58D18613B8 for ; Tue, 6 Apr 2021 13:36:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58D18613B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC7156B007E; Tue, 6 Apr 2021 09:36:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D77176B0080; Tue, 6 Apr 2021 09:36:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF1536B0081; Tue, 6 Apr 2021 09:36:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id A2DB16B007E for ; Tue, 6 Apr 2021 09:36:21 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5F40818030148 for ; Tue, 6 Apr 2021 13:36:21 +0000 (UTC) X-FDA: 78002041362.36.79ED9BE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 09167E000114 for ; Tue, 6 Apr 2021 13:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sFos5Am2WOHKunK4sb1uTLPyIWgheGtp6/8nhKqbdyk=; b=RE2tqCLPmm2p2Jiim5zD/uNDIf 4dYiLD6byhAOHa9CQnPYUuFte6PbKdi/VRbRJode1q3O2/VD/3/EpFfx8BpgGzNuHk+ehhFBK6Pm1 31EYVCfV4hTLzNBmWEaSmhCOp4q5bWa8Ta3DlPmp9bhGBRjwzfCH8FPtRYROvo2PujLx4TGVFmP/4 qmaLpBC7sQHnkLcEURIjo3k71nJSWEDXKQVQfc9UDAyibiQYYWpBo/DJlqYQ+17oKT+KSEbMyaweY zF6fhHt1mGBg00sfF/LXbutqZqWch1YlZaqZpaOar4EsSvjlr/ACp8Uq2cq5hAZx7LdL2kCqQMRu+ t5ziZR6g==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTlqk-00Cron-0w; Tue, 06 Apr 2021 13:35:04 +0000 Date: Tue, 6 Apr 2021 14:34:34 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 08/27] mm: Create FolioFlags Message-ID: <20210406133434.GG3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 09167E000114 X-Stat-Signature: icjzcgj6nfywfc6hbsb9156xcndb1g5s Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617716178-949750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 31, 2021 at 07:47:09PM +0100, Matthew Wilcox (Oracle) wrote: > These new functions are the folio analogues of the PageFlags functions. > If CONFIG_DEBUG_VM_PGFLAGS is enabled, we check the folio is not a tail > page at every invocation. Note that this will also catch the PagePoisoned > case as a poisoned page has every bit set, which would include PageTail. > > This saves 1727 bytes of text with the distro-derived config that > I'm testing due to removing a double call to compound_head() in > PageSwapCache(). Looks good, Reviewed-by: Christoph Hellwig