From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8CDC433ED for ; Tue, 6 Apr 2021 14:48:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85B6D613B8 for ; Tue, 6 Apr 2021 14:48:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85B6D613B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E61A76B0070; Tue, 6 Apr 2021 10:48:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E10206B0080; Tue, 6 Apr 2021 10:48:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C898D6B0083; Tue, 6 Apr 2021 10:48:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id A93EA6B0070 for ; Tue, 6 Apr 2021 10:48:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5469B181AEF1F for ; Tue, 6 Apr 2021 14:48:19 +0000 (UTC) X-FDA: 78002222718.19.E23D06E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 448EC80192E7 for ; Tue, 6 Apr 2021 14:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LcatN0eXO4hy1rj6fn0i4l5iiWPD2BQjKbVyK62ja+g=; b=cI4R966jLOPd7fq/ZEWnxY7Phh qg99KaZnT2dZNnGQr35gIlhGYBPWqbRj3GKbtD6OhcC0+7hBdPgIH3dn1jVz664538BIxs0VrKHno 6r1wQ8pJBC6fes4ZUZtuAqBM5zGT5TAZCDZbkYAYIaKbG7Aut7Lan9OIjTF2aPmgctb9WT/MgV5PP IuydLk+WlIMFYlZvhp2vi3Z8w3csYGHkB8GEuywXGOmcMoZd3k3SMbDn+zDi34R8JwdCBCXucFckr oCVlYP4XVsEMmxCzHsiwUH5hB2paLhr6jHj+LPRB/+wG4pi5jJrfdQ5XZND6l4kv523bj1507BxUi byMbmo5g==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTmz2-00Cxf8-V9; Tue, 06 Apr 2021 14:47:20 +0000 Date: Tue, 6 Apr 2021 15:47:12 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , "Kirill A. Shutemov" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 01/27] mm: Introduce struct folio Message-ID: <20210406144712.GA3087660@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-2-willy@infradead.org> <20210406122918.h5dsnbjhmwpfasf4@box.shutemov.name> <20210406124807.GO2531743@casper.infradead.org> <20210406143150.GA3082513@infradead.org> <20210406144022.GR2531743@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406144022.GR2531743@casper.infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 448EC80192E7 X-Stat-Signature: xgfjcaeyxf6pt61uzgu69p63o3tbg14f Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617720498-267677 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 06, 2021 at 03:40:22PM +0100, Matthew Wilcox wrote: > On Tue, Apr 06, 2021 at 03:31:50PM +0100, Christoph Hellwig wrote: > > > > As Christoph, I'm not a fan of this :/ > > > > > > What would you prefer? > > > > Looking at your full folio series on git.infradead.org, there are a > > total of 12 references to non-page members of struct folio, assuming > > my crude grep that expects a folio to be named folio did not miss any. > > Hmm ... I count more in the filesystems: I only counted the ones that you actually did convert. This add about 80 more. IMHO still not worth doing the union. I'd rather sort this out properl if/when the structures get properly split.