From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E1DC433B4 for ; Tue, 6 Apr 2021 14:56:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8CAF4613B8 for ; Tue, 6 Apr 2021 14:56:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CAF4613B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1249E6B0073; Tue, 6 Apr 2021 10:56:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C2466B0080; Tue, 6 Apr 2021 10:56:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7F0C6B0081; Tue, 6 Apr 2021 10:56:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id C785D6B0073 for ; Tue, 6 Apr 2021 10:56:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7BD2D18010BF4 for ; Tue, 6 Apr 2021 14:56:11 +0000 (UTC) X-FDA: 78002242542.07.2638A9A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id C49E480192DD for ; Tue, 6 Apr 2021 14:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=utRNYwnpm4FcBjJdhPy0mCfMjTjs+CQ5M9mPuIzGgp8=; b=B4sNd7sg32rPyOsIgv2PbVlcbN 7B2vtCRS2jWMF8YCT+TtOfptbT6vEn1bW7PoE1bej4VpqIMjJ3pIdZJPEgmxSADGJnPM5EHmY8XDu WxXL3Zmryrp3/J1FbmZ9V0oI0sW16vJz/vTO0q4E4pe58/O2+ppfW0NZUCUBX8fVrtkeArPRr6rbh Qkc0VfYUGABjpsksTr3+MSSlix59ar1rB3i+DDCf6+vlJiBycap5g1k2yuLgybWa1J7YOhWkOCVH/ 9mL/XljMzMfdFySfO9lRTeLKvl3JoabCNYs9TCoQyiNzOT224PlpqWDMljOLGbzyyiG4JaqBTt86M wbMHdHqQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTn6l-00CyKp-9l; Tue, 06 Apr 2021 14:55:30 +0000 Date: Tue, 6 Apr 2021 15:55:11 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: "Kirill A. Shutemov" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 01/27] mm: Introduce struct folio Message-ID: <20210406145511.GS2531743@casper.infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-2-willy@infradead.org> <20210406122918.h5dsnbjhmwpfasf4@box.shutemov.name> <20210406124807.GO2531743@casper.infradead.org> <20210406143150.GA3082513@infradead.org> <20210406144022.GR2531743@casper.infradead.org> <20210406144712.GA3087660@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406144712.GA3087660@infradead.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C49E480192DD X-Stat-Signature: uobncup8bg3kc9qqzf7nxpwn8emhncuw Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617720965-146132 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 06, 2021 at 03:47:12PM +0100, Christoph Hellwig wrote: > On Tue, Apr 06, 2021 at 03:40:22PM +0100, Matthew Wilcox wrote: > > On Tue, Apr 06, 2021 at 03:31:50PM +0100, Christoph Hellwig wrote: > > > > > As Christoph, I'm not a fan of this :/ > > > > > > > > What would you prefer? > > > > > > Looking at your full folio series on git.infradead.org, there are a > > > total of 12 references to non-page members of struct folio, assuming > > > my crude grep that expects a folio to be named folio did not miss any. > > > > Hmm ... I count more in the filesystems: > > I only counted the ones that you actually did convert. > > This add about 80 more. IMHO still not worth doing the union. I'd > rather sort this out properl if/when the structures get properly split. Assuming we're getting rid of them all though, we have to include: $ git grep 'page->mapping' fs |wc -l 358 $ git grep 'page->index' fs |wc -l 355