From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F3DBC433ED for ; Wed, 7 Apr 2021 02:06:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FDD0613B7 for ; Wed, 7 Apr 2021 02:06:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FDD0613B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=lespinasse.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 300D16B0096; Tue, 6 Apr 2021 22:06:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D7C96B0098; Tue, 6 Apr 2021 22:06:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A0616B0099; Tue, 6 Apr 2021 22:06:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id F27E56B0096 for ; Tue, 6 Apr 2021 22:06:50 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B634C815F for ; Wed, 7 Apr 2021 02:06:50 +0000 (UTC) X-FDA: 78003932580.37.C01D11A Received: from server.lespinasse.org (server.lespinasse.org [63.205.204.226]) by imf12.hostedemail.com (Postfix) with ESMTP id 66C51D2 for ; Wed, 7 Apr 2021 02:06:47 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-11-ed; t=1617761205; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=XhXKF/HlNkEF5SYDx8u8tz5N9qQXfiAGL0LdiGpNeCM=; b=I/g7Gvfz5ftyUgHqNBuPnWTqjssHQ5Xq0vHwEGXlfrdpbRwbuAXpzOPgBeS229wZV8ANB E1zDNGu4gI4arXGAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-11-rsa; t=1617761205; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=XhXKF/HlNkEF5SYDx8u8tz5N9qQXfiAGL0LdiGpNeCM=; b=UDp6TQ0bdsuQQeSHsak7IJ4F9fN5evSiGjUg+WKdiZ/q/i+AxGfP56Nhfb71m6v6HB2Zd uUKW8BiQmOAGAEMHaWrfjy5S1iRoGDD/E3eQoUa9wUD9Q2rucFxLhHnjdngsiq0N3v5cBwT waUMT54SQedejYGhWNwrt/6IB8iQaKMPtVH2jrOT1y6gbe5GSVy0djgbApXcZf4aM3rBrsi dx1erw8y3PKFkpfAEV9T0LSbm3rnG4dH2A1qS19BKMEZQn6+gb2M52n8myZbtZR49+dXH+4 X3X2qbdb+P2clEw8L+nftPMUJX/iWWiSljuelQcex6KCzc0CaUZRtl3LI5FQ== Received: by server.lespinasse.org (Postfix, from userid 1000) id CDE541601D1; Tue, 6 Apr 2021 19:06:45 -0700 (PDT) Date: Tue, 6 Apr 2021 19:06:45 -0700 From: Michel Lespinasse To: Bibo Mao Cc: Linux-MM , Laurent Dufour , Peter Zijlstra , Michal Hocko , Matthew Wilcox , Rik van Riel , Paul McKenney , Andrew Morton , Suren Baghdasaryan , Joel Fernandes , Rom Lemarchand , Linux-Kernel Subject: Re: [RFC PATCH 03/37] do_anonymous_page: use update_mmu_tlb() Message-ID: <20210407020645.GA19721@lespinasse.org> References: <20210407014502.24091-1-michel@lespinasse.org> <20210407014502.24091-4-michel@lespinasse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407014502.24091-4-michel@lespinasse.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 66C51D2 X-Stat-Signature: 9nqjemk5gs4mp15n61xrqjfy1fjio6pu Received-SPF: none (lespinasse.org>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=server.lespinasse.org; client-ip=63.205.204.226 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617761207-970043 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Bibo, You introduced this code in commit 7df676974359f back in May. Could you check that the change is correct ? Thanks, On Tue, Apr 06, 2021 at 06:44:28PM -0700, Michel Lespinasse wrote: > update_mmu_tlb() can be used instead of update_mmu_cache() when the > page fault handler detects that it lost the race to another page fault. > > Signed-off-by: Michel Lespinasse > --- > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 5efa07fb6cdc..8ee4bd239303 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3567,7 +3567,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) > vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, > &vmf->ptl); > if (!pte_none(*vmf->pte)) { > - update_mmu_cache(vma, vmf->address, vmf->pte); > + update_mmu_tlb(vma, vmf->address, vmf->pte); > goto release; > } > > -- > 2.20.1 >