From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EEA7C433ED for ; Wed, 7 Apr 2021 09:37:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B78E56135D for ; Wed, 7 Apr 2021 09:37:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B78E56135D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 376766B007D; Wed, 7 Apr 2021 05:37:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34D346B007E; Wed, 7 Apr 2021 05:37:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2150E6B0080; Wed, 7 Apr 2021 05:37:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id 053346B007D for ; Wed, 7 Apr 2021 05:37:54 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id ABA7B18144D5D for ; Wed, 7 Apr 2021 09:37:54 +0000 (UTC) X-FDA: 78005069268.38.5713210 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf30.hostedemail.com (Postfix) with ESMTP id A8E4AE000105 for ; Wed, 7 Apr 2021 09:37:48 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1DA31B02A; Wed, 7 Apr 2021 09:37:53 +0000 (UTC) Date: Wed, 7 Apr 2021 11:37:49 +0200 From: Oscar Salvador To: Michal Hocko Cc: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Roman Gushchin , Shakeel Butt , David Hildenbrand , Muchun Song , David Rientjes , Miaohe Lin , Peter Zijlstra , Matthew Wilcox , HORIGUCHI NAOYA , "Aneesh Kumar K . V" , Waiman Long , Peter Xu , Mina Almasry , Hillf Danton , Joonsoo Kim , Barry Song , Will Deacon , Andrew Morton Subject: Re: [PATCH v4 5/8] hugetlb: call update_and_free_page without hugetlb_lock Message-ID: <20210407093744.GA11066@linux> References: <20210405230043.182734-1-mike.kravetz@oracle.com> <20210405230043.182734-6-mike.kravetz@oracle.com> <20210407082744.GA10058@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A8E4AE000105 X-Stat-Signature: yjqycpurcw9wp5g9zhn6bkriofujhz87 Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1617788268-795139 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 07, 2021 at 11:28:51AM +0200, Michal Hocko wrote: > An emoty page_list? If yes then sure, this can happen but > list_for_each_entry_safe will simply not iterate. Or what do you mean? Yes, I meant page_list. Yeah, I figured list_for_each_entry_safe() would simply not iterate but I wondered whether we still want the spin_unlock()/spin_lock() in that case. But probably not worth it adding more code, so it is fine. Thanks -- Oscar Salvador SUSE L3