From: SeongJae Park <sj38.park@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: SeongJae Park <sj38.park@gmail.com>,
akpm@linux-foundation.org, SeongJae Park <sjpark@amazon.de>,
Jonathan.Cameron@huawei.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, amit@kernel.org,
benh@kernel.crashing.org, brendanhiggins@google.com,
corbet@lwn.net, david@redhat.com, dwmw@amazon.com,
elver@google.com, fan.du@intel.com, foersleo@amazon.de,
gthelen@google.com, guoju.fgj@alibaba-inc.com, mgorman@suse.de,
minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org,
peterz@infradead.org, riel@surriel.com, rientjes@google.com,
rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com,
shuah@kernel.org, snu@amazon.de, vbabka@suse.cz,
vdavydov.dev@gmail.com, zgf574564920@gmail.com,
linux-damon@amazon.com, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space interface
Date: Sat, 10 Apr 2021 12:57:59 +0200 [thread overview]
Message-ID: <20210410105759.12611-1-sj38.park@gmail.com> (raw)
In-Reply-To: <YHFn5fOTIQQ4TXHA@kroah.com>
From: SeongJae Park <sjpark@amazon.de>
On Sat, 10 Apr 2021 10:55:01 +0200 Greg KH <greg@kroah.com> wrote:
> On Thu, Apr 08, 2021 at 01:48:48PM +0000, SeongJae Park wrote:
> > +static int dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx)
> > +{
> > + const char * const file_names[] = {"attrs", "target_ids"};
> > + const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops};
> > + int i;
> > +
> > + for (i = 0; i < ARRAY_SIZE(file_names); i++)
> > + debugfs_create_file(file_names[i], 0600, dir, ctx, fops[i]);
> > +
> > + return 0;
> > +}
>
> Why do you have a function that can only return 0, actually return
> something? It should be void, right?
You're right, I will make it return void in the next spin.
Thanks,
SeongJae Park
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2021-04-10 10:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 13:48 [PATCH v27 00/13] Introduce Data Access MONitor (DAMON) SeongJae Park
2021-04-08 13:48 ` [PATCH v27 01/13] mm: " SeongJae Park
2021-04-08 13:48 ` [PATCH v27 02/13] mm/damon/core: Implement region-based sampling SeongJae Park
2021-04-08 13:48 ` [PATCH v27 03/13] mm/damon: Adaptively adjust regions SeongJae Park
2021-04-08 13:48 ` [PATCH v27 04/13] mm/idle_page_tracking: Make PG_idle reusable SeongJae Park
2021-04-08 13:48 ` [PATCH v27 05/13] mm/damon: Implement primitives for the virtual memory address spaces SeongJae Park
2021-04-08 13:48 ` [PATCH v27 06/13] mm/damon: Add a tracepoint SeongJae Park
2021-04-08 13:48 ` [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space interface SeongJae Park
2021-04-10 8:55 ` Greg KH
2021-04-10 10:57 ` SeongJae Park [this message]
2021-04-12 11:22 ` SeongJae Park
2021-04-08 13:48 ` [PATCH v27 08/13] mm/damon/dbgfs: Export kdamond pid to the user space SeongJae Park
2021-04-08 13:48 ` [PATCH v27 09/13] mm/damon/dbgfs: Support multiple contexts SeongJae Park
2021-04-08 13:48 ` [PATCH v27 10/13] Documentation: Add documents for DAMON SeongJae Park
2021-04-08 13:48 ` [PATCH v27 11/13] mm/damon: Add kunit tests SeongJae Park
2021-04-08 13:48 ` [PATCH v27 12/13] mm/damon: Add user space selftests SeongJae Park
2021-04-08 13:48 ` [PATCH v27 13/13] MAINTAINERS: Update for DAMON SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210410105759.12611-1-sj38.park@gmail.com \
--to=sj38.park@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=elver@google.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=greg@kroah.com \
--cc=gthelen@google.com \
--cc=guoju.fgj@alibaba-inc.com \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sjpark@amazon.de \
--cc=snu@amazon.de \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=zgf574564920@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).