From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A9B1C433B4 for ; Sat, 10 Apr 2021 15:55:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A4D5C611C9 for ; Sat, 10 Apr 2021 15:55:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4D5C611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DF76D6B006C; Sat, 10 Apr 2021 11:55:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCE7E6B006E; Sat, 10 Apr 2021 11:55:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6FEE8D0002; Sat, 10 Apr 2021 11:55:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id A747E6B006C for ; Sat, 10 Apr 2021 11:55:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5FE5034A3 for ; Sat, 10 Apr 2021 15:55:07 +0000 (UTC) X-FDA: 78016906254.20.9ED9304 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by imf26.hostedemail.com (Postfix) with ESMTP id 8D3C840002CD for ; Sat, 10 Apr 2021 15:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CzOBLJLIpMaSm2apRythmsTcqiiwrKSDjrbInU9e0SA=; b=c5UKjvS8rNqagvElEmnq5mWQ2 sOG6gW99tI6xwZXqcrM0Omsn7OTm2fu3665e5SLzAUZcWgmuvpx4LsuO8/sfRyv5AHrB1VxlWAb+2 zb8sbnGIvkTUbOVv1OeaDlPYJRbaBVxn9aQ7OEXrvQXVMJ89mFmJItp1FPI6+1z4kCSLRgjYKV6Eq 1ehY/+L/+7Sd24BuLZQuq1uqmViCX215IU2khq8hUKbTdXz6jbowwCm1+k1w9WhYpo20Mm1p3GXMQ lWvTKWoggbyjkpAqlg4ihTHh2CWrkU497gIFI6Q5aTR6qrgU8es4zjrms5ywWgA05k/kw4Fv0Ni50 rysPj65UQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52272) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVFwk-0003Cf-AS; Sat, 10 Apr 2021 16:54:54 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lVFwf-0005Xb-GK; Sat, 10 Apr 2021 16:54:49 +0100 Date: Sat, 10 Apr 2021 16:54:49 +0100 From: Russell King - ARM Linux admin To: Matthew Wilcox Cc: Ilias Apalodimas , Jesper Dangaard Brouer , kernel test robot , Linux-MM , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, open list , linux-fsdevel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Linux ARM , "David S. Miller" , Ivan Khoronzhuk , Matteo Croce , "netdev@vger.kernel.org" , Grygorii Strashko Subject: Re: Bogus struct page layout on 32-bit Message-ID: <20210410155449.GI1463@shell.armlinux.org.uk> References: <20210409185105.188284-3-willy@infradead.org> <202104100656.N7EVvkNZ-lkp@intel.com> <20210410024313.GX2531743@casper.infradead.org> <20210410082158.79ad09a6@carbon> <20210410140652.GY2531743@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210410140652.GY2531743@casper.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 8D3C840002CD X-Stat-Signature: hegugz1r8urzcd4npk5nfy91itnc6jhr X-Rspamd-Server: rspam02 Received-SPF: none (armlinux.org.uk>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=pandora.armlinux.org.uk; client-ip=78.32.30.218 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618070103-429855 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 10, 2021 at 03:06:52PM +0100, Matthew Wilcox wrote: > How about moving the flags into the union? A bit messy, but we don't > have to play games with __packed__. Yes, that is probably the better solution, avoiding the games to try and get the union appropriately placed on 32-bit systems. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!