From: Peter Zijlstra <peterz@infradead.org>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, x86@kernel.org,
jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, chris@chris-wilson.co.uk,
intel-gfx@lists.freedesktop.org, linux-mm@kvack.org,
keescook@chromium.org, hch@lst.de
Subject: [PATCH 2/7] xen/gntdev,x86: Remove apply_to_page_range() use from module
Date: Mon, 12 Apr 2021 10:00:14 +0200 [thread overview]
Message-ID: <20210412080611.635125063@infradead.org> (raw)
In-Reply-To: 20210412080012.357146277@infradead.org
Instead of relying on apply_to_page_range() being available to
modules, move its use into core kernel code and export it's
application.
NOTE: ideally we do: use_ptemod = !auto_translate_physmap &&
gnttab_map_avail_bits and remove this hack.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
arch/x86/include/asm/xen/page.h | 2 ++
arch/x86/xen/mmu.c | 26 ++++++++++++++++++++++++++
drivers/xen/gntdev.c | 23 +----------------------
3 files changed, 29 insertions(+), 22 deletions(-)
--- a/arch/x86/include/asm/xen/page.h
+++ b/arch/x86/include/asm/xen/page.h
@@ -370,4 +370,6 @@ static inline unsigned long xen_get_swio
return __get_free_pages(__GFP_NOWARN, order);
}
+extern void xen_set_grant_as_special(struct vm_area_struct *vma);
+
#endif /* _ASM_X86_XEN_PAGE_H */
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -51,3 +51,29 @@ int xen_unmap_domain_gfn_range(struct vm
return -EINVAL;
}
EXPORT_SYMBOL_GPL(xen_unmap_domain_gfn_range);
+
+static int set_grant_ptes_as_special(pte_t *pte, unsigned long addr, void *data)
+{
+ set_pte_at(current->mm, addr, pte, pte_mkspecial(*pte));
+ return 0;
+}
+
+void xen_set_grant_as_special(struct vm_area_struct *vma)
+{
+ if (xen_feature(XENFEAT_gnttab_map_avail_bits))
+ return;
+
+ /*
+ * If the PTEs were not made special by the grant map
+ * hypercall, do so here.
+ *
+ * This is racy since the mapping is already visible
+ * to userspace but userspace should be well-behaved
+ * enough to not touch it until the mmap() call
+ * returns.
+ */
+ apply_to_page_range(vma->vm_mm, vma->vm_start,
+ vma->vm_end - vma->vm_start,
+ set_grant_ptes_as_special, NULL);
+}
+EXPORT_SYMBOL_GPL(xen_set_grant_as_special);
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -278,14 +278,6 @@ static int find_grant_ptes(pte_t *pte, u
return 0;
}
-#ifdef CONFIG_X86
-static int set_grant_ptes_as_special(pte_t *pte, unsigned long addr, void *data)
-{
- set_pte_at(current->mm, addr, pte, pte_mkspecial(*pte));
- return 0;
-}
-#endif
-
int gntdev_map_grant_pages(struct gntdev_grant_map *map)
{
int i, err = 0;
@@ -1040,20 +1032,7 @@ static int gntdev_mmap(struct file *flip
goto out_put_map;
} else {
#ifdef CONFIG_X86
- /*
- * If the PTEs were not made special by the grant map
- * hypercall, do so here.
- *
- * This is racy since the mapping is already visible
- * to userspace but userspace should be well-behaved
- * enough to not touch it until the mmap() call
- * returns.
- */
- if (!xen_feature(XENFEAT_gnttab_map_avail_bits)) {
- apply_to_page_range(vma->vm_mm, vma->vm_start,
- vma->vm_end - vma->vm_start,
- set_grant_ptes_as_special, NULL);
- }
+ xen_set_grant_as_special(vma);
#endif
}
next prev parent reply other threads:[~2021-04-12 8:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 8:00 [PATCH 0/7] mm: Unexport apply_to_page_range() Peter Zijlstra
2021-04-12 8:00 ` [PATCH 1/7] mm: Unexport apply_to_existing_page_range() Peter Zijlstra
2021-04-12 8:13 ` Christoph Hellwig
2021-04-12 8:00 ` Peter Zijlstra [this message]
2021-04-12 8:26 ` [PATCH 2/7] xen/gntdev,x86: Remove apply_to_page_range() use from module Christoph Hellwig
2021-04-12 9:20 ` Peter Zijlstra
2021-04-12 9:26 ` Juergen Gross
2021-04-12 8:00 ` [PATCH 3/7] xen/gntdev: " Peter Zijlstra
2021-04-12 8:27 ` Christoph Hellwig
2021-04-12 9:02 ` Peter Zijlstra
2021-04-12 8:00 ` [PATCH 4/7] mm: Introduce verify_page_range() Peter Zijlstra
2021-04-12 8:28 ` Christoph Hellwig
2021-04-12 9:17 ` Peter Zijlstra
2021-04-12 20:05 ` Kees Cook
2021-04-13 6:54 ` Peter Zijlstra
2021-04-19 23:36 ` Kees Cook
2021-04-13 7:36 ` Peter Zijlstra
2021-04-14 3:01 ` Kees Cook
2021-04-14 7:00 ` Peter Zijlstra
2021-04-12 8:00 ` [PATCH 5/7] xen/privcmd: Use verify_page_range() Peter Zijlstra
2021-04-12 8:28 ` Christoph Hellwig
2021-04-12 8:00 ` [PATCH 6/7] i915: Convert to verify_page_range() Peter Zijlstra
2021-04-12 8:28 ` Christoph Hellwig
2021-04-12 20:08 ` Kees Cook
2021-04-13 6:54 ` Peter Zijlstra
2021-04-14 3:04 ` Kees Cook
2021-04-12 8:00 ` [PATCH 7/7] mm: Unexport apply_to_page_range() Peter Zijlstra
2021-04-12 8:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412080611.635125063@infradead.org \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=chris@chris-wilson.co.uk \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgross@suse.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rodrigo.vivi@intel.com \
--cc=sstabellini@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).