From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467B1C433B4 for ; Mon, 12 Apr 2021 08:27:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E617461243 for ; Mon, 12 Apr 2021 08:27:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E617461243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C8838D0002; Mon, 12 Apr 2021 04:27:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69FB26B006E; Mon, 12 Apr 2021 04:27:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58DDB8D0002; Mon, 12 Apr 2021 04:27:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 405776B006C for ; Mon, 12 Apr 2021 04:27:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E96E64DDA for ; Mon, 12 Apr 2021 08:27:23 +0000 (UTC) X-FDA: 78023035566.09.BBB95F1 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf12.hostedemail.com (Postfix) with ESMTP id BB6D2DE for ; Mon, 12 Apr 2021 08:27:18 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B930E68C4E; Mon, 12 Apr 2021 10:27:21 +0200 (CEST) Date: Mon, 12 Apr 2021 10:27:21 +0200 From: Christoph Hellwig To: Peter Zijlstra Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, x86@kernel.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, keescook@chromium.org, hch@lst.de Subject: Re: [PATCH 3/7] xen/gntdev: Remove apply_to_page_range() use from module Message-ID: <20210412082721.GC4372@lst.de> References: <20210412080012.357146277@infradead.org> <20210412080611.702979288@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210412080611.702979288@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BB6D2DE X-Stat-Signature: swst4d4jqfx5udnzr6hywwd6qws341b5 Received-SPF: none (lst.de>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=verein.lst.de; client-ip=213.95.11.211 X-HE-DKIM-Result: none/none X-HE-Tag: 1618216038-459562 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 12, 2021 at 10:00:15AM +0200, Peter Zijlstra wrote: > --- a/drivers/xen/grant-table.c > +++ b/drivers/xen/grant-table.c > @@ -1591,6 +1591,43 @@ int gnttab_init(void) > } > EXPORT_SYMBOL_GPL(gnttab_init); > > +#include > +#include "gntdev-common.h" Can't we keep the includes at the top of the file? Otherwise looks good: Reviewed-by: Christoph Hellwig