From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 957D4C433B4 for ; Tue, 13 Apr 2021 20:17:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 397D861242 for ; Tue, 13 Apr 2021 20:17:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 397D861242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A2B4D6B0071; Tue, 13 Apr 2021 16:17:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FE376B0072; Tue, 13 Apr 2021 16:17:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82C4D6B0073; Tue, 13 Apr 2021 16:17:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id 5F95E6B0071 for ; Tue, 13 Apr 2021 16:17:56 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0BBAE82499B9 for ; Tue, 13 Apr 2021 20:17:56 +0000 (UTC) X-FDA: 78028454952.13.D3455FC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id AA7CD5001528 for ; Tue, 13 Apr 2021 20:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618345075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F+gpcGbjpJnW75HsT83fn38nMLIN2HNyr9uneAl6PwM=; b=PFTzUEe7naAwv1tg/lw2jI+nZ29tD1Qv8kH/WNLzROftHVzCaQM3n/mg8j+3B3oIfJTiSH 4tC9Ys090lFi25UN6GBpeuiqKIS+J0IyWbzKPraFlRb7/hJpaRGyxofSNGOn90AcI5SEov vhKGnGGXgqRPWYEykvJpx2teM8wBRyk= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-sz-UNxUuOe-ouIllghC1OA-1; Tue, 13 Apr 2021 16:17:53 -0400 X-MC-Unique: sz-UNxUuOe-ouIllghC1OA-1 Received: by mail-qv1-f69.google.com with SMTP id a7so10734539qvx.10 for ; Tue, 13 Apr 2021 13:17:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F+gpcGbjpJnW75HsT83fn38nMLIN2HNyr9uneAl6PwM=; b=Y9Y7LyNKFgxd5GLQwvwPtbSy0hfZKxzkUfHyMtXgfQnL98Q8wS5TXTcjxhTPRft6vV rClfKbnXeroQ21yN2naAWnjL2UmCKseulXPlXFrDHQu7fHEse3ZG9YZKDC3WvMxl/DkW j82c/i7WMp/6bZW72hohnT5fpW9uQNmRIoeUS7rRCrkxzsEHmUsRKzXPcXDDRbndZ/4t /HZsSpiHJ3RZIzoXezWMK8d1iDhDOPOBwm6b+mLQ7AGxl3cIvMuIsovqBtHDyZldhSHa ZwB9F6zUrThIB7ziP4xjcQgqJlCve8Vg5mdxOcaCaMfuM+5TGiAgPVC6BKnzHga9Xr+Q J0qg== X-Gm-Message-State: AOAM5319pX3wxhD1g+Hg7sGaEE8CDLwmAi9Zr8wskupCZG54MXPzXyEA za3XumUCazfr7bmORX6tPfcTGPrWf7OI+oX+YEskROL5dCnYjJ2fbK+MyAajYFAceDyCcbWrOMy CJgivd8NZ7J0= X-Received: by 2002:ac8:7fcd:: with SMTP id b13mr31785949qtk.68.1618345072907; Tue, 13 Apr 2021 13:17:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzm8QhI4YsPfqqtubp6A3TgshHmvxjOKTuerTRIoNikR75RHHmVPZbkbKxWJoODRS6zRKCi6Q== X-Received: by 2002:ac8:7fcd:: with SMTP id b13mr31785923qtk.68.1618345072692; Tue, 13 Apr 2021 13:17:52 -0700 (PDT) Received: from xz-x1 (bras-base-toroon474qw-grc-88-174-93-75-154.dsl.bell.ca. [174.93.75.154]) by smtp.gmail.com with ESMTPSA id q67sm8814016qkb.89.2021.04.13.13.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 13:17:52 -0700 (PDT) Date: Tue, 13 Apr 2021 16:17:50 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrea Arcangeli , Andrew Morton , Hugh Dickins , Jerome Glisse , Joe Perches , Lokesh Gidra , Mike Kravetz , Mike Rapoport , Shaohua Li , Shuah Khan , Stephen Rothwell , Wang Qing , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Brian Geffon , "Dr . David Alan Gilbert" , Mina Almasry , Oliver Upton Subject: Re: [PATCH v2 6/9] userfaultfd/selftests: create alias mappings in the shmem test Message-ID: <20210413201750.GF4440@xz-x1> References: <20210413051721.2896915-1-axelrasmussen@google.com> <20210413051721.2896915-7-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20210413051721.2896915-7-axelrasmussen@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AA7CD5001528 X-Stat-Signature: a3gdpwn1gb4khqb834rbcbg9yutgmxhn Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618345074-140518 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 12, 2021 at 10:17:18PM -0700, Axel Rasmussen wrote: > static void shmem_allocate_area(void **alloc_area) > { > - unsigned long offset = > - alloc_area == (void **)&area_src ? 0 : nr_pages * page_size; > + void *area_alias = NULL; > + bool is_src = alloc_area == (void **)&area_src; > + unsigned long offset = is_src ? 0 : nr_pages * page_size; > > *alloc_area = mmap(NULL, nr_pages * page_size, PROT_READ | PROT_WRITE, > MAP_SHARED, shm_fd, offset); > if (*alloc_area == MAP_FAILED) > err("mmap of memfd failed"); > + > + area_alias = mmap(NULL, nr_pages * page_size, PROT_READ | PROT_WRITE, > + MAP_SHARED, shm_fd, offset); > + if (area_alias == MAP_FAILED) > + err("mmap of memfd alias failed"); > + > + if (is_src) > + area_src_alias = area_alias; > + else > + area_dst_alias = area_alias; > +} It would be nice if shmem_allocate_area() could merge with hugetlb_allocate_area() somehow, but not that urgent. Reviewed-by: Peter Xu -- Peter Xu