From: kernel test robot <lkp@intel.com>
To: Yu Zhao <yuzhao@google.com>, linux-mm@kvack.org
Cc: kbuild-all@lists.01.org, Alex Shi <alexs@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Benjamin Manes <ben.manes@gmail.com>,
Dave Chinner <david@fromorbit.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Hillf Danton <hdanton@sina.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2 15/16] mm: multigenerational lru: Kconfig
Date: Wed, 14 Apr 2021 00:19:13 +0800 [thread overview]
Message-ID: <202104140006.njJ9QXLu-lkp@intel.com> (raw)
In-Reply-To: <20210413065633.2782273-16-yuzhao@google.com>
[-- Attachment #1: Type: text/plain, Size: 4859 bytes --]
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/x86/core]
[also build test ERROR on cgroup/for-next tip/x86/mm fuse/for-next tip/perf/core tip/sched/core linus/master v5.12-rc7]
[cannot apply to hnaz-linux-mm/master next-20210413]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yu-Zhao/Multigenerational-LRU-Framework/20210413-145844
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 99cb64de36d5c9397a664808b92943e35bdce25e
config: um-allmodconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/f05f4c64bb8f0b8bcc40c9931f51bffdb6502cdd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yu-Zhao/Multigenerational-LRU-Framework/20210413-145844
git checkout f05f4c64bb8f0b8bcc40c9931f51bffdb6502cdd
# save the attached .config to linux build tree
make W=1 ARCH=um
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
mm/vmscan.c: In function 'walk_pmd_range_unlocked':
>> mm/vmscan.c:5055:24: error: implicit declaration of function 'pmd_pfn'; did you mean 'pmd_off'? [-Werror=implicit-function-declaration]
5055 | unsigned long pfn = pmd_pfn(val);
| ^~~~~~~
| pmd_off
>> mm/vmscan.c:5057:9: error: implicit declaration of function 'pmd_young'; did you mean 'pte_young'? [-Werror=implicit-function-declaration]
5057 | if (!pmd_young(val)) {
| ^~~~~~~~~
| pte_young
cc1: some warnings being treated as errors
--
cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
mm/memcontrol.c: In function 'mem_cgroup_attach':
>> mm/memcontrol.c:6176:3: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
6176 | ;
| ^
vim +5055 mm/vmscan.c
4aa138b42a5c9f Yu Zhao 2021-04-13 5029
4aa138b42a5c9f Yu Zhao 2021-04-13 5030 static bool walk_pmd_range_unlocked(pud_t *pud, unsigned long start, unsigned long end,
4aa138b42a5c9f Yu Zhao 2021-04-13 5031 struct mm_walk *walk)
4aa138b42a5c9f Yu Zhao 2021-04-13 5032 {
4aa138b42a5c9f Yu Zhao 2021-04-13 5033 int i;
4aa138b42a5c9f Yu Zhao 2021-04-13 5034 pmd_t *pmd;
4aa138b42a5c9f Yu Zhao 2021-04-13 5035 unsigned long next;
4aa138b42a5c9f Yu Zhao 2021-04-13 5036 int young = 0;
4aa138b42a5c9f Yu Zhao 2021-04-13 5037 struct mm_walk_args *args = walk->private;
4aa138b42a5c9f Yu Zhao 2021-04-13 5038
4aa138b42a5c9f Yu Zhao 2021-04-13 5039 VM_BUG_ON(pud_leaf(*pud));
4aa138b42a5c9f Yu Zhao 2021-04-13 5040
4aa138b42a5c9f Yu Zhao 2021-04-13 5041 pmd = pmd_offset(pud, start & PUD_MASK);
4aa138b42a5c9f Yu Zhao 2021-04-13 5042 restart:
4aa138b42a5c9f Yu Zhao 2021-04-13 5043 for (i = pmd_index(start); start != end; i++, start = next) {
4aa138b42a5c9f Yu Zhao 2021-04-13 5044 pmd_t val = pmd_read_atomic(pmd + i);
4aa138b42a5c9f Yu Zhao 2021-04-13 5045
4aa138b42a5c9f Yu Zhao 2021-04-13 5046 next = pmd_addr_end(start, end);
4aa138b42a5c9f Yu Zhao 2021-04-13 5047
4aa138b42a5c9f Yu Zhao 2021-04-13 5048 barrier();
4aa138b42a5c9f Yu Zhao 2021-04-13 5049 if (!pmd_present(val) || is_huge_zero_pmd(val)) {
4aa138b42a5c9f Yu Zhao 2021-04-13 5050 args->mm_stats[MM_LEAF_HOLE]++;
4aa138b42a5c9f Yu Zhao 2021-04-13 5051 continue;
4aa138b42a5c9f Yu Zhao 2021-04-13 5052 }
4aa138b42a5c9f Yu Zhao 2021-04-13 5053
4aa138b42a5c9f Yu Zhao 2021-04-13 5054 if (pmd_trans_huge(val)) {
4aa138b42a5c9f Yu Zhao 2021-04-13 @5055 unsigned long pfn = pmd_pfn(val);
4aa138b42a5c9f Yu Zhao 2021-04-13 5056
4aa138b42a5c9f Yu Zhao 2021-04-13 @5057 if (!pmd_young(val)) {
4aa138b42a5c9f Yu Zhao 2021-04-13 5058 args->mm_stats[MM_LEAF_OLD]++;
4aa138b42a5c9f Yu Zhao 2021-04-13 5059 continue;
4aa138b42a5c9f Yu Zhao 2021-04-13 5060 }
4aa138b42a5c9f Yu Zhao 2021-04-13 5061
4aa138b42a5c9f Yu Zhao 2021-04-13 5062 if (pfn < args->start_pfn || pfn >= args->end_pfn) {
4aa138b42a5c9f Yu Zhao 2021-04-13 5063 args->mm_stats[MM_LEAF_OTHER_NODE]++;
4aa138b42a5c9f Yu Zhao 2021-04-13 5064 continue;
4aa138b42a5c9f Yu Zhao 2021-04-13 5065 }
4aa138b42a5c9f Yu Zhao 2021-04-13 5066
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24403 bytes --]
next prev parent reply other threads:[~2021-04-13 16:27 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 6:56 [PATCH v2 00/16] Multigenerational LRU Framework Yu Zhao
2021-04-13 6:56 ` [PATCH v2 01/16] include/linux/memcontrol.h: do not warn in page_memcg_rcu() if !CONFIG_MEMCG Yu Zhao
2021-04-13 6:56 ` [PATCH v2 02/16] include/linux/nodemask.h: define next_memory_node() if !CONFIG_NUMA Yu Zhao
2021-04-13 6:56 ` [PATCH v2 03/16] include/linux/huge_mm.h: define is_huge_zero_pmd() if !CONFIG_TRANSPARENT_HUGEPAGE Yu Zhao
2021-04-13 6:56 ` [PATCH v2 04/16] include/linux/cgroup.h: export cgroup_mutex Yu Zhao
2021-04-13 6:56 ` [PATCH v2 05/16] mm/swap.c: export activate_page() Yu Zhao
2021-04-13 6:56 ` [PATCH v2 06/16] mm, x86: support the access bit on non-leaf PMD entries Yu Zhao
2021-04-13 6:56 ` [PATCH v2 07/16] mm/vmscan.c: refactor shrink_node() Yu Zhao
2021-04-13 6:56 ` [PATCH v2 08/16] mm: multigenerational lru: groundwork Yu Zhao
2021-04-13 6:56 ` [PATCH v2 09/16] mm: multigenerational lru: activation Yu Zhao
2021-04-13 6:56 ` [PATCH v2 10/16] mm: multigenerational lru: mm_struct list Yu Zhao
2021-04-14 14:36 ` Matthew Wilcox
2021-04-13 6:56 ` [PATCH v2 11/16] mm: multigenerational lru: aging Yu Zhao
2021-04-13 6:56 ` [PATCH v2 12/16] mm: multigenerational lru: eviction Yu Zhao
2021-04-13 6:56 ` [PATCH v2 13/16] mm: multigenerational lru: page reclaim Yu Zhao
2021-04-13 6:56 ` [PATCH v2 14/16] mm: multigenerational lru: user interface Yu Zhao
2021-04-13 22:39 ` kernel test robot
2021-04-13 6:56 ` [PATCH v2 15/16] mm: multigenerational lru: Kconfig Yu Zhao
2021-04-13 16:19 ` kernel test robot [this message]
2021-04-14 4:54 ` kernel test robot
2021-04-13 6:56 ` [PATCH v2 16/16] mm: multigenerational lru: documentation Yu Zhao
2021-04-13 7:51 ` [PATCH v2 00/16] Multigenerational LRU Framework SeongJae Park
2021-04-13 16:13 ` Jens Axboe
2021-04-13 16:42 ` SeongJae Park
2021-04-13 23:14 ` Dave Chinner
2021-04-14 2:29 ` Rik van Riel
2021-04-14 4:13 ` Yu Zhao
2021-04-14 6:15 ` Huang, Ying
2021-04-14 7:58 ` Yu Zhao
2021-04-14 8:27 ` Huang, Ying
2021-04-14 13:51 ` Rik van Riel
2021-04-14 15:56 ` Andi Kleen
2021-04-14 15:58 ` [page-reclaim] " Shakeel Butt
2021-04-14 18:45 ` Yu Zhao
2021-04-14 15:51 ` Andi Kleen
2021-04-14 15:58 ` Rik van Riel
2021-04-14 19:14 ` Yu Zhao
2021-04-14 19:41 ` Rik van Riel
2021-04-14 20:08 ` Yu Zhao
2021-04-14 19:04 ` Yu Zhao
2021-04-15 3:00 ` Andi Kleen
2021-04-15 7:13 ` Yu Zhao
2021-04-15 8:19 ` Huang, Ying
2021-04-15 9:57 ` Michel Lespinasse
2021-04-24 2:33 ` Yu Zhao
2021-04-24 3:30 ` Andi Kleen
2021-04-24 4:16 ` Yu Zhao
2021-04-14 3:40 ` Yu Zhao
2021-04-14 4:50 ` Dave Chinner
2021-04-14 7:16 ` Yu Zhao
2021-04-14 10:00 ` Yu Zhao
2021-04-15 1:36 ` Dave Chinner
2021-04-24 21:21 ` Yu Zhao
2021-04-14 14:43 ` Jens Axboe
2021-04-14 19:42 ` Yu Zhao
2021-04-15 1:21 ` Dave Chinner
2021-04-14 17:43 ` Johannes Weiner
2021-04-27 10:35 ` Yu Zhao
2021-04-29 23:46 ` Konstantin Kharlamov
2021-04-30 6:37 ` Konstantin Kharlamov
2021-04-30 19:31 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104140006.njJ9QXLu-lkp@intel.com \
--to=lkp@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=axboe@kernel.dk \
--cc=ben.manes@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@fromorbit.com \
--cc=hdanton@sina.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).