From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D65C433ED for ; Thu, 15 Apr 2021 09:34:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E6076139A for ; Thu, 15 Apr 2021 09:34:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E6076139A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D231C6B0036; Thu, 15 Apr 2021 05:34:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD33E6B006C; Thu, 15 Apr 2021 05:34:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC2A06B0070; Thu, 15 Apr 2021 05:34:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id A10FD6B0036 for ; Thu, 15 Apr 2021 05:34:57 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5C62B12D0 for ; Thu, 15 Apr 2021 09:34:57 +0000 (UTC) X-FDA: 78034092234.01.8F8A10C Received: from outbound-smtp14.blacknight.com (outbound-smtp14.blacknight.com [46.22.139.231]) by imf26.hostedemail.com (Postfix) with ESMTP id 6765240002DD for ; Thu, 15 Apr 2021 09:34:52 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp14.blacknight.com (Postfix) with ESMTPS id 5C83C1C39E4 for ; Thu, 15 Apr 2021 10:34:54 +0100 (IST) Received: (qmail 8512 invoked from network); 15 Apr 2021 09:34:54 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 15 Apr 2021 09:34:54 -0000 Date: Thu, 15 Apr 2021 10:34:52 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Linux-MM , Linux-RT-Users , LKML , Chuck Lever , Jesper Dangaard Brouer , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Michal Hocko Subject: Re: [PATCH 04/11] mm/vmstat: Inline NUMA event counter updates Message-ID: <20210415093452.GI3697@techsingularity.net> References: <20210414133931.4555-1-mgorman@techsingularity.net> <20210414133931.4555-5-mgorman@techsingularity.net> <6b25af48-9c6e-2c55-03d5-763de4aba149@suse.cz> <411a753f-ce03-389d-9a9f-93d17b284862@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <411a753f-ce03-389d-9a9f-93d17b284862@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6765240002DD X-Stat-Signature: qomgcc5jb9fof3w4jadn7ubwci35k11o Received-SPF: none (techsingularity.net>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=outbound-smtp14.blacknight.com; client-ip=46.22.139.231 X-HE-DKIM-Result: none/none X-HE-Tag: 1618479292-937067 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 14, 2021 at 06:26:25PM +0200, Vlastimil Babka wrote: > On 4/14/21 6:20 PM, Vlastimil Babka wrote: > > On 4/14/21 3:39 PM, Mel Gorman wrote: > >> __count_numa_event is small enough to be treated similarly to > >> __count_vm_event so inline it. > >> > >> Signed-off-by: Mel Gorman > > > > Acked-by: Vlastimil Babka > > > >> --- > >> include/linux/vmstat.h | 9 +++++++++ > >> mm/vmstat.c | 9 --------- > >> 2 files changed, 9 insertions(+), 9 deletions(-) > >> > >> diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > >> index fc14415223c5..dde4dec4e7dd 100644 > >> --- a/include/linux/vmstat.h > >> +++ b/include/linux/vmstat.h > >> @@ -237,6 +237,15 @@ static inline unsigned long zone_page_state_snapshot(struct zone *zone, > >> } > >> > >> #ifdef CONFIG_NUMA > >> +/* See __count_vm_event comment on why raw_cpu_inc is used. */ > >> +static inline void > >> +__count_numa_event(struct zone *zone, enum numa_stat_item item) > >> +{ > >> + struct per_cpu_zonestat __percpu *pzstats = zone->per_cpu_zonestats; > >> + > >> + raw_cpu_inc(pzstats->vm_numa_event[item]); > >> +} > >> + > >> extern void __count_numa_event(struct zone *zone, enum numa_stat_item item); > > Ah, but the line above should be removed. > Yes it should! -- Mel Gorman SUSE Labs