From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B527C433ED for ; Thu, 15 Apr 2021 17:11:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64CE06117A for ; Thu, 15 Apr 2021 17:11:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64CE06117A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E582D6B0036; Thu, 15 Apr 2021 13:11:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2DE26B006C; Thu, 15 Apr 2021 13:11:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA7AD6B0070; Thu, 15 Apr 2021 13:11:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id AC4156B0036 for ; Thu, 15 Apr 2021 13:11:42 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6D55C18264701 for ; Thu, 15 Apr 2021 17:11:42 +0000 (UTC) X-FDA: 78035243244.39.9BEC01A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 348A240002D3 for ; Thu, 15 Apr 2021 17:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YwgbDheT+MJJ4trDHQZMYorZHJyXvzB0bzY8L8H53Zg=; b=pqDZ5QWhUwnCMzzTpH+57MdG8e g0vSEvFaeMGsKZ8bh0uo5UlIzHiiUgtJXiYwSvzacGqhh6T6NUMa7H0FmZtHyRyC3p6SM9J82c7nt wJ42qJWzFe26oOKJIu3NFrFYbbArdbYa6HooTaeAKc+NP3I6rczNl963yeZNi4aDr08izYDfRM3GD lb8BDY8K66PWBgEDvI5KTaFM7dI7gmB3dxzh0jphKMJR33jYTh5zvGwlqJWJriDwVOvk8EUzYHs4K WlLbiUz0IBvw1/FZNpfVY943UN1CCV+CB9CaByZSj9Jt8m13uHY+rBW34SoQuSqLRa7q6/dbT68+r T9a1b7tg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lX5Vj-008r8z-8x; Thu, 15 Apr 2021 17:10:41 +0000 Date: Thu, 15 Apr 2021 18:10:35 +0100 From: Matthew Wilcox To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun Subject: Re: [PATCH v3 0/5] mm/memcg: Reduce kmemcache memory accounting overhead Message-ID: <20210415171035.GB2531743@casper.infradead.org> References: <20210414012027.5352-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414012027.5352-1-longman@redhat.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 348A240002D3 X-Stat-Signature: 4aqoa44sd177zmdhsxf6q44qjfte516h Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618506699-210967 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 13, 2021 at 09:20:22PM -0400, Waiman Long wrote: > With memory accounting disable, the run time was 2.848s. With memory > accounting enabled, the run times with the application of various > patches in the patchset were: > > Applied patches Run time Accounting overhead Overhead %age > --------------- -------- ------------------- ------------- > None 10.800s 7.952s 100.0% > 1-2 9.140s 6.292s 79.1% > 1-3 7.641s 4.793s 60.3% > 1-5 6.801s 3.953s 49.7% I think this is a misleading way to report the overhead. I would have said: 10.800s 7.952s 279.2% 9.140s 6.292s 220.9% 7.641s 4.793s 168.3% 6.801s 3.953s 138.8%