From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C96C433B4 for ; Thu, 29 Apr 2021 09:13:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 72FDF6143E for ; Thu, 29 Apr 2021 09:13:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72FDF6143E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C36066B006E; Thu, 29 Apr 2021 05:13:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBD5C6B0070; Thu, 29 Apr 2021 05:13:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E97F6B0071; Thu, 29 Apr 2021 05:13:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 79FBC6B006E for ; Thu, 29 Apr 2021 05:13:26 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3C40E12E9 for ; Thu, 29 Apr 2021 09:13:26 +0000 (UTC) X-FDA: 78084841212.35.AACC17F Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf12.hostedemail.com (Postfix) with ESMTP id 82258EF for ; Thu, 29 Apr 2021 09:13:14 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13T99dR3082829; Thu, 29 Apr 2021 09:13:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=oLvXnfGjfzXPrzkheewhWCuu3Z+Vz/jJWr/MyK/Cjy4=; b=PoX2SnRFfG4iNxRoarqGfS9b749HNXJywGT1Bg505tAgbUIg197NIZ7AO/EcEP2eEJAL P7UWaD7+CWc8Go6x67a6WCOWBdfI/OZRPqDo1+BxxqQITYQ2+C/WjneL+ncqLDYjvQz5 RaoJetk5SkgbLkHMNtIRdJOxFn+l7skSTSvyxRSZwpB2ZP0H91/r9ak8SZAQ5ndVuixb XnfCcc2af0S2sZtQYBboPmL0VL9uQ+sh9lYGkrDbnXoA4qeiXM6lGHNN91DcFHpkVIrb jOcEtpkIlpies5ua10F5RNyS8fiqTCeym6dbk9NuTfuTOXhTdTSJlrR54f+u5feL5ocY jQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 385aft3njv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Apr 2021 09:13:23 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13T9ArAc106330; Thu, 29 Apr 2021 09:13:22 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3030.oracle.com with ESMTP id 3848f0t4cx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Apr 2021 09:13:22 +0000 Received: from userp3030.oracle.com (userp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 13T9DMLh117063; Thu, 29 Apr 2021 09:13:22 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 3848f0t4c8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Apr 2021 09:13:22 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 13T9DLrO019583; Thu, 29 Apr 2021 09:13:21 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 29 Apr 2021 09:13:20 +0000 Date: Thu, 29 Apr 2021 12:13:12 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Leon Romanovsky Cc: lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Saeed Mahameed , Moshe Shemesh Subject: [linux-next:master 2524/14231] drivers/net/ethernet/mellanox/mlx5/core/main.c:1245 mlx5_init_one() warn: missing error code 'err' Message-ID: <202104212004.VsZ0pGAe-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-GUID: O8exUBbD_qH6pY1kdRXAOmdChzS4jdzy X-Proofpoint-ORIG-GUID: O8exUBbD_qH6pY1kdRXAOmdChzS4jdzy X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9968 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1011 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104290065 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 82258EF X-Stat-Signature: 447o4mrfwx4nbhar3azrgssyp4wt5ay3 Received-SPF: none (oracle.com>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=userp2130.oracle.com; client-ip=156.151.31.86 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619687594-496191 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b74523885a715463203d4ccc3cf8c85952d3701a commit: 6dea2f7eff9659049f90922283756830364e6278 [2524/14231] net/mlx5: Separate probe vs. reload flows config: x86_64-randconfig-m001-20210421 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/main.c:1245 mlx5_init_one() warn: missing error code 'err' Old smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/main.c:1322 mlx5_load_one() warn: missing error code 'err' vim +/err +1245 drivers/net/ethernet/mellanox/mlx5/core/main.c 59211bd3b6329c Mohamad Haj Yahia 2016-09-09 1237 6dea2f7eff9659 Leon Romanovsky 2020-11-02 1238 int mlx5_init_one(struct mlx5_core_dev *dev) a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1239 { a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1240 int err = 0; a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1241 a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1242 mutex_lock(&dev->intf_state_mutex); a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1243 if (test_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state)) { a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1244 mlx5_core_warn(dev, "interface is up, NOP\n"); a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 @1245 goto out; Is this an error path? If not then consider doing setting the err code inside the if statement: if (test_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state)) { mlx5_core_warn(dev, "interface is up, NOP\n"); err = 0; goto out; } 1bde6e301cf621 Eli Cohen 2014-01-14 1246 } a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1247 /* remove any previous indication of internal error */ a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1248 dev->state = MLX5_DEVICE_STATE_UP; e126ba97dba9ed Eli Cohen 2013-07-07 1249 6dea2f7eff9659 Leon Romanovsky 2020-11-02 1250 err = mlx5_function_setup(dev, true); a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1251 if (err) 4f7400d5cbaef6 Shay Drory 2020-05-06 1252 goto err_function; e126ba97dba9ed Eli Cohen 2013-07-07 1253 a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1254 err = mlx5_init_once(dev); a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1255 if (err) { 98a8e6fc482d96 Huy Nguyen 2019-03-29 1256 mlx5_core_err(dev, "sw objs init failed\n"); a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1257 goto function_teardown; a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1258 } cd23b14b654769 Eli Cohen 2013-07-18 1259 a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1260 err = mlx5_load(dev); a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1261 if (err) a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1262 goto err_load; a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1263 98f91c45769302 Parav Pandit 2020-05-15 1264 set_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state); 98f91c45769302 Parav Pandit 2020-05-15 1265 a6f3b62386a02c Michael Guralnik 2019-11-20 1266 err = mlx5_devlink_register(priv_to_devlink(dev), dev->device); a6f3b62386a02c Michael Guralnik 2019-11-20 1267 if (err) a6f3b62386a02c Michael Guralnik 2019-11-20 1268 goto err_devlink_reg; a925b5e309c9b9 Leon Romanovsky 2020-10-08 1269 a925b5e309c9b9 Leon Romanovsky 2020-10-08 1270 err = mlx5_register_device(dev); a925b5e309c9b9 Leon Romanovsky 2020-10-08 1271 if (err) a925b5e309c9b9 Leon Romanovsky 2020-10-08 1272 goto err_register; a925b5e309c9b9 Leon Romanovsky 2020-10-08 1273 4162f58b476b24 Parav Pandit 2020-05-01 1274 mutex_unlock(&dev->intf_state_mutex); 4162f58b476b24 Parav Pandit 2020-05-01 1275 return 0; a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1276 a925b5e309c9b9 Leon Romanovsky 2020-10-08 1277 err_register: a925b5e309c9b9 Leon Romanovsky 2020-10-08 1278 mlx5_devlink_unregister(priv_to_devlink(dev)); a6f3b62386a02c Michael Guralnik 2019-11-20 1279 err_devlink_reg: 98f91c45769302 Parav Pandit 2020-05-15 1280 clear_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state); a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1281 mlx5_unload(dev); a80d1b68c8b7a0 Saeed Mahameed 2019-03-29 1282 err_load: 59211bd3b6329c Mohamad Haj Yahia 2016-09-09 1283 mlx5_cleanup_once(dev); e161105e58da81 Saeed Mahameed 2019-03-29 1284 function_teardown: 6dea2f7eff9659 Leon Romanovsky 2020-11-02 1285 mlx5_function_teardown(dev, true); 4f7400d5cbaef6 Shay Drory 2020-05-06 1286 err_function: 89d44f0a6c732d Majd Dibbiny 2015-10-14 1287 dev->state = MLX5_DEVICE_STATE_INTERNAL_ERROR; 4162f58b476b24 Parav Pandit 2020-05-01 1288 out: 89d44f0a6c732d Majd Dibbiny 2015-10-14 1289 mutex_unlock(&dev->intf_state_mutex); e126ba97dba9ed Eli Cohen 2013-07-07 1290 return err; e126ba97dba9ed Eli Cohen 2013-07-07 1291 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org