From: Matthew Wilcox <willy@infradead.org>
To: Xiongwei Song <sxwjean@me.com>
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Xiongwei Song <sxwjean@gmail.com>
Subject: Re: [PATCH] mm: append __GFP_COMP flag for trace_malloc
Date: Tue, 27 Apr 2021 03:53:58 +0100 [thread overview]
Message-ID: <20210427025358.GV235567@casper.infradead.org> (raw)
In-Reply-To: <1619491400-1904-1-git-send-email-sxwjean@me.com>
On Tue, Apr 27, 2021 at 10:43:20AM +0800, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
>
> When calling kmalloc_order, the flags should include __GFP_COMP here,
> so that trace_malloc can trace the precise flags.
I suppose that depends on your point of view. Should we report the
flags used by the caller, or the flags that we used to allocate memory?
And why does it matter?
next prev parent reply other threads:[~2021-04-27 2:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 2:43 [PATCH] mm: append __GFP_COMP flag for trace_malloc Xiongwei Song
2021-04-27 2:53 ` Matthew Wilcox [this message]
2021-04-27 3:29 ` Xiongwei Song
2021-04-27 3:36 ` Matthew Wilcox
2021-04-27 4:11 ` Xiongwei Song
2021-04-27 5:30 ` Xiongwei Song
2021-04-27 11:25 ` Matthew Wilcox
2021-04-28 3:05 ` Xiongwei Song
2021-05-03 12:35 ` Vlastimil Babka
2021-05-07 5:41 ` Xiongwei Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427025358.GV235567@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).