From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F178FC433B4 for ; Tue, 27 Apr 2021 12:14:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6937F613E8 for ; Tue, 27 Apr 2021 12:14:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6937F613E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=synopsys.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D3C306B0036; Tue, 27 Apr 2021 08:14:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D13116B006E; Tue, 27 Apr 2021 08:14:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDC836B0070; Tue, 27 Apr 2021 08:14:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id A23A86B0036 for ; Tue, 27 Apr 2021 08:14:15 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6508A4DC8 for ; Tue, 27 Apr 2021 12:14:15 +0000 (UTC) X-FDA: 78078039270.31.EE7B392 Received: from smtprelay-out1.synopsys.com (smtprelay-out1.synopsys.com [149.117.87.133]) by imf23.hostedemail.com (Postfix) with ESMTP id 9B0E3A000394 for ; Tue, 27 Apr 2021 12:14:10 +0000 (UTC) Received: from mailhost.synopsys.com (mdc-mailhost1.synopsys.com [10.225.0.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id BDFAEC0552; Tue, 27 Apr 2021 12:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1619525653; bh=KRq0A/+QMHj5BLNmcw2miTkzyZiUHS4WDq7zHqV5LRg=; h=From:To:Cc:Subject:Date:From; b=DEgE3TErxy9aZN26Qcm5kU1BgX5NR3HwR+1aS4xNW9Uosf5lcpyVAFKbfRYJ9CnjY Vr2nwDhfnpnC51OzFJSDg6xTr8eAaQiNLqRgeMp8hpT51y/YX46GDT79LCokdPhokd VneN74QM5RrQdkRXk6pZdBMZsDbiNm7TYUsCslwSbGChjE5T0FIzPTVvA0Qz67MKmB 8ktP2a9wD+CkrB/LoUHrHvSS1XQqcS6HRk6KriAtHgLI12jUyJnLt3yfoxjoEkiE9w HnEe/FouDKZGFaG9EXVVaUENU9hhv9wezeoOm0PUei2VHs/BLqhsI2FOJeQcxVHg0p ABZcpiljJkX4A== Received: from ru20arcgnu1.internal.synopsys.com (ru20arcgnu1.internal.synopsys.com [10.121.9.48]) by mailhost.synopsys.com (Postfix) with ESMTP id 5B1C6A005C; Tue, 27 Apr 2021 12:14:07 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Vladimir Isaev To: linux-snps-arc@lists.infradead.org Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rppt@linux.ibm.com, Vladimir Isaev , Vineet Gupta Subject: [PATCH v2] ARC: Use max_high_pfn as a HIGHMEM zone border Date: Tue, 27 Apr 2021 15:13:54 +0300 Message-Id: <20210427121354.3620-1-isaev@synopsys.com> X-Mailer: git-send-email 2.16.2 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9B0E3A000394 X-Stat-Signature: adbya5dffs9r38h8g3pjabwocbo96c41 Received-SPF: none (synopsys.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=smtprelay-out1.synopsys.com; client-ip=149.117.87.133 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619525650-375273 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit 4af22ded0ecf ("arc: fix memory initialization for systems with two memory banks") fixed highmem, but for the PAE case it causes bug messages: BUG: Bad page state in process swapper pfn:80000 page:(ptrval) refcount:0 mapcount:1 mapping:00000000 index:0x0 pfn:0x80000 flags: 0x0() raw: 00000000 00000100 00000122 00000000 00000000 00000000 00000000 00000000 raw: 00000000 page dumped because: nonzero mapcount Modules linked in: CPU: 0 PID: 0 Comm: swapper Not tainted 5.12.0-rc5-00003-g1e43c377a79f #1 Stack Trace: arc_unwind_core+0xe8/0x118 Disabling lock debugging due to kernel taint This is because the fix expects highmem to be always less than lowmem and uses min_low_pfn as an upper zone border for highmem. max_high_pfn should be ok for both highmem and highmem+PAE cases. Signed-off-by: Vladimir Isaev Cc: Mike Rapoport Cc: Vineet Gupta --- Changes for v2: - Revised commit message and added comment to code --- arch/arc/mm/init.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/arc/mm/init.c b/arch/arc/mm/init.c index ce07e697916c..1bcc6985b9a0 100644 --- a/arch/arc/mm/init.c +++ b/arch/arc/mm/init.c @@ -157,7 +157,16 @@ void __init setup_arch_memory(void) min_high_pfn = PFN_DOWN(high_mem_start); max_high_pfn = PFN_DOWN(high_mem_start + high_mem_sz); - max_zone_pfn[ZONE_HIGHMEM] = min_low_pfn; + /* + * max_high_pfn should be ok here for both HIGHMEM and HIGHMEM+PAE. + * For HIGHMEM without PAE max_high_pfn should be less than + * min_low_pfn to guarantee that these two regions don't overlap. + * For PAE case highmem is greater than lowmem, so it is natural + * to use max_high_pfn. + * + * In both cases, holes should be handled by pfn_valid(). + */ + max_zone_pfn[ZONE_HIGHMEM] = max_high_pfn; high_memory = (void *)(min_high_pfn << PAGE_SHIFT); -- 2.16.2