From: kernel test robot <lkp@intel.com>
To: Michel Lespinasse <michel@lespinasse.org>,
Linux-MM <linux-mm@kvack.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Cc: kbuild-all@lists.01.org, Laurent Dufour <ldufour@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Michal Hocko <mhocko@suse.com>,
Matthew Wilcox <willy@infradead.org>,
Rik van Riel <riel@surriel.com>,
Paul McKenney <paulmck@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Suren Baghdasaryan <surenb@google.com>
Subject: Re: [PATCH 16/29] mm: add pte_map_lock() and pte_spinlock()
Date: Sat, 1 May 2021 07:33:35 +0800 [thread overview]
Message-ID: <202105010703.Z0kxSm7D-lkp@intel.com> (raw)
In-Reply-To: <20210430195232.30491-17-michel@lespinasse.org>
[-- Attachment #1: Type: text/plain, Size: 11895 bytes --]
Hi Michel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/x86/mm]
[also build test ERROR on arm64/for-next/core linus/master v5.12]
[cannot apply to hnaz-linux-mm/master next-20210430]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Michel-Lespinasse/Speculative-page-faults-anon-vmas-only/20210501-035602
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a500fc918f7b8dc3dff2e6c74f3e73e856c18248
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/284898f9c11d755d2b231794fc7529d562f8e918
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Michel-Lespinasse/Speculative-page-faults-anon-vmas-only/20210501-035602
git checkout 284898f9c11d755d2b231794fc7529d562f8e918
# save the attached .config to linux build tree
make W=1 W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/mm.h:33,
from include/linux/kallsyms.h:12,
from include/linux/bpf.h:20,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/mm.h: In function 'pte_map_lock':
include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \
| ^~~~~~~~~~~
include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map'
2205 | pte_t *__pte = pte_offset_map(pmd, address); \
| ^~~~~~~~~~~~~~
include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock'
3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
| ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/highmem.h:14,
from include/linux/pagemap.h:11,
from include/linux/blkdev.h:14,
from include/linux/blk-cgroup.h:23,
from include/linux/writeback.h:14,
from include/linux/memcontrol.h:22,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/highmem-internal.h: At top level:
>> include/linux/highmem-internal.h:98:21: error: conflicting types for 'kmap_atomic'
98 | static inline void *kmap_atomic(struct page *page)
| ^~~~~~~~~~~
In file included from include/linux/mm.h:33,
from include/linux/kallsyms.h:12,
from include/linux/bpf.h:20,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/pgtable.h:79:12: note: previous implicit declaration of 'kmap_atomic' was here
79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \
| ^~~~~~~~~~~
include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map'
2205 | pte_t *__pte = pte_offset_map(pmd, address); \
| ^~~~~~~~~~~~~~
include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock'
3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from include/linux/mm.h:33,
from include/linux/kallsyms.h:12,
from include/linux/bpf.h:20,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/mm.h: In function 'pte_map_lock':
include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \
| ^~~~~~~~~~~
include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map'
2205 | pte_t *__pte = pte_offset_map(pmd, address); \
| ^~~~~~~~~~~~~~
include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock'
3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
| ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/highmem.h:14,
from include/linux/pagemap.h:11,
from include/linux/blkdev.h:14,
from include/linux/blk-cgroup.h:23,
from include/linux/writeback.h:14,
from include/linux/memcontrol.h:22,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/highmem-internal.h: At top level:
>> include/linux/highmem-internal.h:98:21: error: conflicting types for 'kmap_atomic'
98 | static inline void *kmap_atomic(struct page *page)
| ^~~~~~~~~~~
In file included from include/linux/mm.h:33,
from include/linux/kallsyms.h:12,
from include/linux/bpf.h:20,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/pgtable.h:79:12: note: previous implicit declaration of 'kmap_atomic' was here
79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \
| ^~~~~~~~~~~
include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map'
2205 | pte_t *__pte = pte_offset_map(pmd, address); \
| ^~~~~~~~~~~~~~
include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock'
3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:116: arch/x86/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1233: prepare0] Error 2
make[1]: Target 'modules_prepare' not remade because of errors.
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'modules_prepare' not remade because of errors.
--
In file included from include/linux/mm.h:33,
from include/linux/kallsyms.h:12,
from include/linux/bpf.h:20,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/mm.h: In function 'pte_map_lock':
include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \
| ^~~~~~~~~~~
include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map'
2205 | pte_t *__pte = pte_offset_map(pmd, address); \
| ^~~~~~~~~~~~~~
include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock'
3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
| ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/highmem.h:14,
from include/linux/pagemap.h:11,
from include/linux/blkdev.h:14,
from include/linux/blk-cgroup.h:23,
from include/linux/writeback.h:14,
from include/linux/memcontrol.h:22,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/highmem-internal.h: At top level:
>> include/linux/highmem-internal.h:98:21: error: conflicting types for 'kmap_atomic'
98 | static inline void *kmap_atomic(struct page *page)
| ^~~~~~~~~~~
In file included from include/linux/mm.h:33,
from include/linux/kallsyms.h:12,
from include/linux/bpf.h:20,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/pgtable.h:79:12: note: previous implicit declaration of 'kmap_atomic' was here
79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \
| ^~~~~~~~~~~
include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map'
2205 | pte_t *__pte = pte_offset_map(pmd, address); \
| ^~~~~~~~~~~~~~
include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock'
3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:116: arch/x86/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1233: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/kmap_atomic +98 include/linux/highmem-internal.h
13f876ba77ebd5 Thomas Gleixner 2020-11-03 97
13f876ba77ebd5 Thomas Gleixner 2020-11-03 @98 static inline void *kmap_atomic(struct page *page)
13f876ba77ebd5 Thomas Gleixner 2020-11-03 99 {
13f876ba77ebd5 Thomas Gleixner 2020-11-03 100 return kmap_atomic_prot(page, kmap_prot);
13f876ba77ebd5 Thomas Gleixner 2020-11-03 101 }
13f876ba77ebd5 Thomas Gleixner 2020-11-03 102
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64672 bytes --]
next prev parent reply other threads:[~2021-04-30 23:34 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210430195232.30491-1-michel@lespinasse.org>
2021-04-30 19:52 ` [PATCH 01/29] mm: export dump_mm Michel Lespinasse
2021-04-30 19:52 ` [PATCH 02/29] mmap locking API: mmap_lock_is_contended returns a bool Michel Lespinasse
2021-04-30 19:52 ` [PATCH 03/29] mmap locking API: name the return values Michel Lespinasse
2021-04-30 19:52 ` [PATCH 04/29] do_anonymous_page: use update_mmu_tlb() Michel Lespinasse
2021-06-10 0:38 ` Suren Baghdasaryan
2021-04-30 19:52 ` [PATCH 05/29] do_anonymous_page: reduce code duplication Michel Lespinasse
2021-04-30 19:52 ` [PATCH 06/29] mm: introduce CONFIG_SPECULATIVE_PAGE_FAULT Michel Lespinasse
2021-04-30 19:52 ` [PATCH 07/29] x86/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT Michel Lespinasse
2021-04-30 19:52 ` [PATCH 08/29] mm: add FAULT_FLAG_SPECULATIVE flag Michel Lespinasse
2021-06-10 0:58 ` Suren Baghdasaryan
2021-04-30 19:52 ` [PATCH 09/29] mm: add do_handle_mm_fault() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 10/29] mm: add per-mm mmap sequence counter for speculative page fault handling Michel Lespinasse
2021-04-30 19:52 ` [PATCH 11/29] mm: rcu safe vma freeing Michel Lespinasse
2021-04-30 19:52 ` [PATCH 12/29] x86/mm: attempt speculative mm faults first Michel Lespinasse
2021-04-30 19:52 ` [PATCH 13/29] mm: add speculative_page_walk_begin() and speculative_page_walk_end() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 14/29] mm: refactor __handle_mm_fault() / handle_pte_fault() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 15/29] mm: implement speculative handling in __handle_mm_fault() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 16/29] mm: add pte_map_lock() and pte_spinlock() Michel Lespinasse
2021-04-30 23:33 ` kernel test robot [this message]
2021-04-30 23:45 ` kernel test robot
2021-04-30 19:52 ` [PATCH 17/29] mm: implement speculative handling in do_anonymous_page() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 18/29] mm: enable speculative fault handling through do_anonymous_page() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 19/29] mm: implement speculative handling in do_numa_page() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 20/29] mm: enable speculative fault " Michel Lespinasse
2021-04-30 19:52 ` [PATCH 21/29] mm: implement speculative handling in wp_page_copy() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 22/29] mm: implement and enable speculative fault handling in handle_pte_fault() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 23/29] mm: implement speculative handling in do_swap_page() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 24/29] mm: enable speculative fault handling through do_swap_page() Michel Lespinasse
2021-04-30 19:52 ` [PATCH 25/29] mm: disable speculative faults for single threaded user space Michel Lespinasse
2021-04-30 19:52 ` [PATCH 26/29] mm: disable rcu safe vma freeing " Michel Lespinasse
2021-04-30 19:52 ` [PATCH 27/29] mm: anon spf statistics Michel Lespinasse
2021-04-30 22:52 ` kernel test robot
2021-04-30 19:52 ` [PATCH 28/29] arm64/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT Michel Lespinasse
2021-04-30 19:52 ` [PATCH 29/29] arm64/mm: attempt speculative mm faults first Michel Lespinasse
2021-04-30 19:52 ` [PATCH 30/31] powerpc/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT Michel Lespinasse
2021-04-30 19:52 ` [PATCH 31/31] powerpc/mm: attempt speculative mm faults first Michel Lespinasse
2021-04-30 22:46 ` [PATCH 00/29] Speculative page faults (anon vmas only) Michel Lespinasse
2021-05-03 18:11 ` Michel Lespinasse
2021-05-17 17:57 ` Paul E. McKenney
2021-05-20 22:10 ` Suren Baghdasaryan
2021-05-20 23:08 ` Paul E. McKenney
2021-06-01 7:41 ` Michel Lespinasse
2021-06-01 20:18 ` Paul E. McKenney
2021-06-01 20:23 ` Paul E. McKenney
2021-06-14 7:04 ` Michel Lespinasse
2021-05-01 19:56 ` Theodore Ts'o
2021-05-01 21:19 ` Michel Lespinasse
2021-06-17 13:46 ` David Hildenbrand
2021-07-09 10:41 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105010703.Z0kxSm7D-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=michel@lespinasse.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).