From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83428C433B4 for ; Sat, 1 May 2021 14:41:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6A606157F for ; Sat, 1 May 2021 14:41:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6A606157F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 50E1B6B006C; Sat, 1 May 2021 10:41:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AB646B006E; Sat, 1 May 2021 10:41:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 324776B0070; Sat, 1 May 2021 10:41:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 144CC6B006C for ; Sat, 1 May 2021 10:41:19 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BD9F0181AEF2A for ; Sat, 1 May 2021 14:41:18 +0000 (UTC) X-FDA: 78092925036.28.BA5D37B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf28.hostedemail.com (Postfix) with ESMTP id E7AA12000241 for ; Sat, 1 May 2021 14:41:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619880077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XFT2YwbpQ0f/mkF5D9dK/HAkZJgZN+Yb5Re5f3Vl/pw=; b=A9NGJyOqwTBEBzV9u3xMp4yWIcRlkMeX9oJ8PeDmQqj1RyXT13HB++BcuqamcHRzi6ieGe XPf79aAlReSbkw9ssHdeo5PrtXOyXuY6TyRk7OrP64u0lX4BXnFJVZiu/6yLjuRx1oy6Z2 qkYaC+2RXU6PHwAmJ/qwEJe8/KlUkls= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-IuW2x8G0PlWr3-NCYr70dg-1; Sat, 01 May 2021 10:41:16 -0400 X-MC-Unique: IuW2x8G0PlWr3-NCYr70dg-1 Received: by mail-il1-f198.google.com with SMTP id f12-20020a056e0204ccb02901613aa15edfso1083175ils.5 for ; Sat, 01 May 2021 07:41:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YnWb2IPj59++E0ETRcLd7/SnBjta6bFGoaxLShBdHqM=; b=I3xmbb/HwlaPU+j/Lj1oxKVSRhPNFsbJOCcBGQy7Wo1hWJZ4udUU9u1FwrUvyuK6lV Q1Dk92lnnlGKqXUIEgroEfDj8jAK+F6zH0wGods0oDlAMQgu+lN7GJqjRv+LsQceTQ3z YUQrKPvQ9FGejOoNsmbhGLALVILenZZfYNN4/sVpi7xiZlVZDq3S7WQmXDje2LbMwJ0L 0xAeHZzU/NCLRK3HX8Md/WgS5vWrDP/5VRmIsMp2ndPlkAl+oNLqPKBcEUu1XlITTF+5 cLo+Ph8KKYXFBvCYNt7hOKV5VowcCvFVrqRykyz5YmbdGT85OdLBHitSWYcffV1fM4K+ W9+Q== X-Gm-Message-State: AOAM531cBHkb69tpEK0gfRk9dklGHlWuK7yGh11XbQbMwCyjrl8OOJQn 07TY3r/u6RAvacRJ0DOyZmuyAeJT3tl+h/IgmbqNiqMwMxYlxc4vHl+G/xiCrjSk0mBkpf6S+rD 4SyeLNK8/lrsIAn9zQt6wd0keKfFYUmB94xlAK7m87eLFsVq/3JHEo2Ks7dxh X-Received: by 2002:a5d:80d5:: with SMTP id h21mr7790089ior.11.1619880075215; Sat, 01 May 2021 07:41:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxk5BPbkl7SuSYEyonzwXYuuG8gmydSHTQr3+3evv96mDR8iybcSTj18drwijRs3fWsXT+7ig== X-Received: by 2002:a5d:80d5:: with SMTP id h21mr7790067ior.11.1619880074946; Sat, 01 May 2021 07:41:14 -0700 (PDT) Received: from localhost.localdomain (bras-base-toroon474qw-grc-72-184-145-4-219.dsl.bell.ca. [184.145.4.219]) by smtp.gmail.com with ESMTPSA id k2sm2649343ilq.71.2021.05.01.07.41.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 May 2021 07:41:14 -0700 (PDT) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Hugh Dickins , Andrew Morton , Andrea Arcangeli , peterx@redhat.com, Mike Kravetz , Axel Rasmussen Subject: [PATCH 0/2] mm/hugetlb: Fix issues on file sealing and fork Date: Sat, 1 May 2021 10:41:08 -0400 Message-Id: <20210501144110.8784-1-peterx@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A9NGJyOq; spf=none (imf28.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E7AA12000241 X-Stat-Signature: yihsn95b1krchbganzw3tzy8pwd8crjf Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619880078-255535 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hugh reported issue with F_SEAL_FUTURE_WRITE not applied correctly to=0D hugetlbfs, which I can easily verify using the memfd_test program, which se= ems=0D that the program is hardly run with hugetlbfs pages (as by default shmem).= =0D =0D Meanwhile I found another probably even more severe issue on that hugetlb f= ork=0D won't wr-protect child cow pages, so child can potentially write to parent= =0D private pages. Patch 2 addresses that.=0D =0D After this series applied, "memfd_test hugetlbfs" should start to pass.=0D =0D Please review, thanks.=0D =0D Peter Xu (2):=0D mm/hugetlb: Fix F_SEAL_FUTURE_WRITE=0D mm/hugetlb: Fix cow where page writtable in child=0D =0D fs/hugetlbfs/inode.c | 5 +++++=0D include/linux/mm.h | 32 ++++++++++++++++++++++++++++++++=0D mm/hugetlb.c | 2 ++=0D mm/shmem.c | 22 ++++------------------=0D 4 files changed, 43 insertions(+), 18 deletions(-)=0D =0D --=20=0D 2.31.1=0D =0D