From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CEB1C433ED for ; Mon, 3 May 2021 22:57:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5BE2E61244 for ; Mon, 3 May 2021 22:57:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BE2E61244 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C72C6B0036; Mon, 3 May 2021 18:57:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 677AE6B006E; Mon, 3 May 2021 18:57:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EFCC6B0070; Mon, 3 May 2021 18:57:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 3549D6B0036 for ; Mon, 3 May 2021 18:57:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E3DB23631 for ; Mon, 3 May 2021 22:57:07 +0000 (UTC) X-FDA: 78101432094.05.11D2A1F Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf26.hostedemail.com (Postfix) with ESMTP id 9D78C40002E6 for ; Mon, 3 May 2021 22:56:56 +0000 (UTC) Received: by mail-qk1-f182.google.com with SMTP id o27so6838215qkj.9 for ; Mon, 03 May 2021 15:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xZZm+3MFuedFCkj1MfVgDeM954nHR/3fXds6exXmQfs=; b=ouRSQEEjT38vBUuV862SeUlllVCT6eH9A/DLELLKUUCUzA1ShVzuWVXQ1MBHwfUp52 o2iY2zmGF5v6LzhQq+GBDBerKVAePtFNVbGHvM38jkoESd9bfzmAI5TW5EmfL78E08Qn KIGOFGei7/yO8yCpBYVzXmS09DZEEm+pTY6CGCqEpqr9/YKTEYQHHgmnMtxfiJhxhwEM PI6Kaqk2dLQBbp3lySC34PVTv8PJZyC4fg+IILviuxHg1B8L5kSFMxjKrsIeWCcV13AT K2K+mR+5wr9SajVl5e5SOe9bFPiH9IuQFOm4a7VNUrSG+YlFkkc7yhkY+MYykwPRCxJe dU1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xZZm+3MFuedFCkj1MfVgDeM954nHR/3fXds6exXmQfs=; b=mBN+/Kmb5+2aPJngJMer1qrhxbVlVbX5ZMzdCCYFjnHw+sPm0Knco7pNOsCSYAlNoD XIjeQ+vZHz2GPf3STGgLaj7LS2wlTlNoGPx51+XE93s60x/vcjmzsiYZW69F0mOBcfVR CNrcnRGBFY3fXM8GAZv4oEhhPK+mgoBXKH/A9/QP5FBTTfB5nv3ut7Gqo+SbJ9GK6b45 sUbB37rtof0DiF9C1JT0ZLqvlhXNHo66jlBBS4WGxpr+Bz3UZq2h6FZEcG4x5yA/2DDE Kmxjij5gYR6yYWLLGcF/eyWfy3f0sLn/ipBOmZ4vKWHnFF3Y+j8KXf+cqo923kvCrfT7 ElVw== X-Gm-Message-State: AOAM533v3CA4tOkfqn4hnTjRFk2XhuDdCV4nQ6OvgtdkPZCOfN+Dqhw9 rIm0/MwqBZFUUlSL2UjUPYNRbw== X-Google-Smtp-Source: ABdhPJwB6nytiC0oDMbKJRBwSIes/jqgsePpJ+MXFQRNiesNGamVx4ATl+XqEZHAz4GA6Yzrb48bvQ== X-Received: by 2002:a37:a9c8:: with SMTP id s191mr6160737qke.430.1620082626750; Mon, 03 May 2021 15:57:06 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id c17sm897865qtd.71.2021.05.03.15.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 15:57:06 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1ldhUv-00H3QZ-2z; Mon, 03 May 2021 19:57:05 -0300 Date: Mon, 3 May 2021 19:57:05 -0300 From: Jason Gunthorpe To: John Hubbard Cc: Logan Gunthorpe , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Christian =?utf-8?B?S8O2bmln?= , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy Subject: Re: [PATCH 04/16] PCI/P2PDMA: Refactor pci_p2pdma_map_type() to take pagmap and device Message-ID: <20210503225705.GA2047089@ziepe.ca> References: <20210408170123.8788-1-logang@deltatee.com> <20210408170123.8788-5-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=ouRSQEEj; dmarc=none; spf=pass (imf26.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.182 as permitted sender) smtp.mailfrom=jgg@ziepe.ca X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9D78C40002E6 X-Stat-Signature: s5d65rgx75p6wppbfnai85mig4nxg4bm Received-SPF: none (ziepe.ca>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-qk1-f182.google.com; client-ip=209.85.222.182 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620082616-727532 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 03, 2021 at 02:54:26PM -0700, John Hubbard wrote: > I guess my main concern here is that there are these pci*() functions > that somehow want to pass around struct device. Well, this is the main issue - helpers being used inside IOMMU code should not be called pci* functions. This is some generic device p2p interface that happens to only support PCI to PCI transfers today. Jason