From: Peter Xu <peterx@redhat.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Axel Rasmussen <axelrasmussen@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
peterx@redhat.com, Mike Kravetz <mike.kravetz@oracle.com>,
Hugh Dickins <hughd@google.com>
Subject: [PATCH v2 0/2] mm/hugetlb: Fix issues on file sealing and fork
Date: Mon, 3 May 2021 19:43:54 -0400 [thread overview]
Message-ID: <20210503234356.9097-1-peterx@redhat.com> (raw)
v2:
- Move seal check to be after setting VM_HUGETLB [Mike]
- Rewrite commit message for patch 2, explaining more on why it got broken
- Add r-bs for Mike
Hugh reported issue with F_SEAL_FUTURE_WRITE not applied correctly to
hugetlbfs, which I can easily verify using the memfd_test program, which seems
that the program is hardly run with hugetlbfs pages (as by default shmem).
Meanwhile I found another probably even more severe issue on that hugetlb fork
won't wr-protect child cow pages, so child can potentially write to parent
private pages. Patch 2 addresses that.
After this series applied, "memfd_test hugetlbfs" should start to pass.
Please review, thanks.
Peter Xu (2):
mm/hugetlb: Fix F_SEAL_FUTURE_WRITE
mm/hugetlb: Fix cow where page writtable in child
fs/hugetlbfs/inode.c | 5 +++++
include/linux/mm.h | 32 ++++++++++++++++++++++++++++++++
mm/hugetlb.c | 1 +
mm/shmem.c | 22 ++++------------------
4 files changed, 42 insertions(+), 18 deletions(-)
--
2.31.1
next reply other threads:[~2021-05-03 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 23:43 Peter Xu [this message]
2021-05-03 23:43 ` [PATCH v2 1/2] mm/hugetlb: Fix F_SEAL_FUTURE_WRITE Peter Xu
2021-05-03 23:43 ` [PATCH v2 2/2] mm/hugetlb: Fix cow where page writtable in child Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503234356.9097-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).