From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BACCC433B4 for ; Sun, 9 May 2021 19:39:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F13C6023C for ; Sun, 9 May 2021 19:38:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F13C6023C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 27B6A6B0071; Sun, 9 May 2021 15:38:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 205CF6B0072; Sun, 9 May 2021 15:38:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A6036B0073; Sun, 9 May 2021 15:38:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id E245E6B0072 for ; Sun, 9 May 2021 15:38:57 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 91049181AF5C3 for ; Sun, 9 May 2021 19:38:57 +0000 (UTC) X-FDA: 78122705514.13.5D6EA33 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf23.hostedemail.com (Postfix) with ESMTP id E3CFDA000380 for ; Sun, 9 May 2021 19:38:47 +0000 (UTC) Received: by mail-lj1-f180.google.com with SMTP id w4so18153314ljw.9 for ; Sun, 09 May 2021 12:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S8tyYOINgJcgXO+YLeHnUlDVZZruEdZrDr6md8OI68k=; b=nzlu7ccem0ygsiY/jJ0x16lK73WjRmh51B0MtwxG3bflCWQEcPuh5mOREu5EmGPZ5B CC/WfyY/pGPTn6gfZq5uu5F26Vm4vqWf21hIl6ey2hLhXx/BoRdZOR8LMoq3HhtAG7vx giNPFVzOMbameC316jucY9r6OuSbFqBOUsBBKOSliqXCd2PCcJSk9OOGGHfeou4KN1Ch oC/MrMUjGWP/z2VL1S1h1perKLwI00rajDsMI1u0/5RLWjmzS5jumBGY80DlopOtZokG l0Pcnw0ze7ZguflS6CS+4Dke8VFGlVwB6PEwatDZ3zICvqrv1z/8ddaRnRrcl0Id9VOZ pYwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S8tyYOINgJcgXO+YLeHnUlDVZZruEdZrDr6md8OI68k=; b=hfCYFKT6CkT1tuuTKZsEM6Pc3qj5VhCcjpvSnxDjWTZBC+tVOdsY6SQik3OlnenjmL Pywjl8Jn56ygkx4XseuR+82SOpuT/OPymwYo4Fsxitba8K9B9T6f5Q0z7jc1Rfnon1Mc Wc5l8iITHuFhKnQ9l11ROGC4Z84h7jgC9LvQ7BAAxA/2vO8dSAjWFF+FkJzDKxwk1+i2 0bb1GaNZ1rcx1O2YjRgJAtBr+rGis+Yy2iqEfPxRcRkpRzTVSXdDLR3EvUBK0tJ3fvMs 04qVDYAqrmkpkYU4iVrM2i6Sc5oI3I8iJ6aRT+PiGimSJ1LXVIpgFVBaHKpKTYb/Tutv ZFWQ== X-Gm-Message-State: AOAM532JIkvuH4eurnMA5rYPfwRV0C2kW1LTBc6jJ17enSYB2paM/ZO8 l9D0/h04LYYzmb9QNHx2dn/YFgOpgVM= X-Google-Smtp-Source: ABdhPJz4+CgRWqWhVIi9vQherdRk/qSSdjAHrJnWqHztMNOv2DvPjKazUo0hPzXDsA4SYTO7xFWqbQ== X-Received: by 2002:a2e:7005:: with SMTP id l5mr945485ljc.150.1620589135987; Sun, 09 May 2021 12:38:55 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id m17sm1999269lfh.146.2021.05.09.12.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 May 2021 12:38:55 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Matthew Wilcox , Nicholas Piggin , Mel Gorman , Uladzislau Rezki , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH v2 2/2] mm/vmalloc: Print a warning message first on failure Date: Sun, 9 May 2021 21:38:44 +0200 Message-Id: <20210509193844.2562-2-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210509193844.2562-1-urezki@gmail.com> References: <20210509193844.2562-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=nzlu7cce; spf=pass (imf23.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: pcejpho1mssu3mfkbj8ums3tw5inpnhe X-Rspamd-Queue-Id: E3CFDA000380 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail-lj1-f180.google.com; client-ip=209.85.208.180 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620589127-275499 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When a memory allocation for array of pages are not succeed emit a warning message as a first step and then perform the further cleanup. Signed-off-by: Uladzislau Rezki (Sony) --- Makefile | 2 +- mm/vmalloc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index bb50a5ac2e13..1d658e171495 100644 --- a/Makefile +++ b/Makefile @@ -430,7 +430,7 @@ HOSTCXX =3D g++ endif =20 export KBUILD_USERCFLAGS :=3D -Wall -Wmissing-prototypes -Wstrict-protot= ypes \ - -O2 -fomit-frame-pointer -std=3Dgnu89 + -O0 -g -fomit-frame-pointer -std=3Dgnu89 export KBUILD_USERLDFLAGS :=3D =20 KBUILD_HOSTCFLAGS :=3D $(KBUILD_USERCFLAGS) $(HOST_LFS_CFLAGS) $(HOSTC= FLAGS) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index dbc6744400d5..1f664a17d9ea 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2781,11 +2781,11 @@ static void *__vmalloc_area_node(struct vm_struct= *area, gfp_t gfp_mask, } =20 if (!area->pages) { - free_vm_area(area); warn_alloc(gfp_mask, NULL, "vmalloc size %lu allocation failure: " "page array size %lu allocation failed", nr_small_pages * PAGE_SIZE, array_size); + free_vm_area(area); return NULL; } =20 --=20 2.20.1