From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75845C433ED for ; Sun, 9 May 2021 20:05:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C6875613FA for ; Sun, 9 May 2021 20:05:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6875613FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 238166B0070; Sun, 9 May 2021 16:05:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E8086B0071; Sun, 9 May 2021 16:05:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 061F66B0072; Sun, 9 May 2021 16:05:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id DA74F6B0070 for ; Sun, 9 May 2021 16:05:23 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8F4E168A9 for ; Sun, 9 May 2021 20:05:23 +0000 (UTC) X-FDA: 78122772126.07.D29ADFE Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf29.hostedemail.com (Postfix) with ESMTP id 0B0D3D7 for ; Sun, 9 May 2021 20:05:16 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id c3so20237066lfs.7 for ; Sun, 09 May 2021 13:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=npmUVefuE46eM3ogeUz4VwY3gJhf4/3KKClnpwMMoeY=; b=XxexnP8+u5CnpofwBxpa1i9ih0aC8zaFXlwzuBjK+mbLPXhqjnXTtfUTGmBlRux1LU svH5YyQN/SrZewXJnGDZaMOnzgqjsBS45hxr1soQA9o+ISdFKYCEhkYWE3ue7g5FJIcp VkHbqQ1NF1dnr0mAANRxU+Kvc1tz9cn+nWNjZA/3wUPU2pOdTtA2G2qvkOdEUx8aU3tY P94ldTSdLyxtQZ3S1EuKj7L6CY9hcLCOGNo9M1mgTbs8/mYGexyLyaAV1fz55vdUbvtG axFv2MX8DTkHUs/OaMSOLWushKwQn8lg8mV5VHHykglBPiZWwwZZKRZ9PcdMAGAIV21U pBrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=npmUVefuE46eM3ogeUz4VwY3gJhf4/3KKClnpwMMoeY=; b=An0jtbzlD3ntPseB7tjjJ6Xmoc3Ml/2vGDhA/+jqy+sePPEdRW7InZUTD8e66pXIBO uJUdYpjasWS/Zrvd7v0YetepINKXAwxKpwNLj3fKA+bA/THRXHIVugj8CQSoPtb+cV/N 4ALOc8nQ91t7Qsz+CDaOnDbHGy2mKjswZbrJIGIHe9u9ctHHQdouq6OPlI4bG6qDcnT4 OhmabFZB+mekel1GJVT7/mH9Ar0zC9ybzQNcMl8miODKWht7UC9SDSYrnbraCW5lJm0x nejxwL8SGbSFcSkFwYZik2FsxDKjsMqA3XYgRdWxukwPih5BAve6tcajrPkbIsRS0a5M s31Q== X-Gm-Message-State: AOAM530XjPOJ6bCHUpZQsaytZMHXaEkFFepq7vuSZJNkazNElTmR4UAC 8S4mY1UbT1b99m60QzRrSWU= X-Google-Smtp-Source: ABdhPJx6HdRQ64D88RqxJGC6OleuSYWafTfE90HTmpGcenBo4GKy2UbDjLVR3y4ASLvyl2EbFaRqBQ== X-Received: by 2002:a05:6512:149:: with SMTP id m9mr14065946lfo.157.1620590721858; Sun, 09 May 2021 13:05:21 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id z11sm2003605lfr.73.2021.05.09.13.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 May 2021 13:05:21 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sun, 9 May 2021 22:05:19 +0200 To: Matthew Wilcox Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Nicholas Piggin , Mel Gorman , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH v2 2/2] mm/vmalloc: Print a warning message first on failure Message-ID: <20210509200519.GA3016@pc638.lan> References: <20210509193844.2562-1-urezki@gmail.com> <20210509193844.2562-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0B0D3D7 X-Stat-Signature: axbwywi3q9th4kgu5beussi7oar74zmq Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=XxexnP8+; spf=pass (imf29.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail-lf1-f51.google.com; client-ip=209.85.167.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620590716-505550 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 09, 2021 at 08:47:12PM +0100, Matthew Wilcox wrote: > On Sun, May 09, 2021 at 09:38:44PM +0200, Uladzislau Rezki (Sony) wrote: > > export KBUILD_USERCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes \ > > - -O2 -fomit-frame-pointer -std=gnu89 > > + -O0 -g -fomit-frame-pointer -std=gnu89 > > You clearly didn't intend to submit this portion ... > I sent a v3 that does not include it. That was added accidentally. > > +++ b/mm/vmalloc.c > > @@ -2781,11 +2781,11 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > > } > > > > if (!area->pages) { > > - free_vm_area(area); > > warn_alloc(gfp_mask, NULL, > > "vmalloc size %lu allocation failure: " > > "page array size %lu allocation failed", > > nr_small_pages * PAGE_SIZE, array_size); > > + free_vm_area(area); > > return NULL; > > } > > I think this is a bad idea. We're clearly low on memory (a memory > allocation just failed). We should free the memory we have allocated > to improve the chances of the warning message making it out. Not sure if i fully follow you here. We do free the memory. The intention was to print a warning message first because, if, potentially, the free_vm_area(area) also does some prints it would be a bit messy from the point what has been broken first. So, could you please clarify what was your concern? -- Vlad Rezki