From: Jan Kara <jack@suse.cz>
To: Chi Wu <wuchi.zero@gmail.com>
Cc: jack@suse.cz, akpm@linux-foundation.org, axboe@fb.com,
hcochran@kernelspring.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mszeredi@redhat.com, sedat.dilek@gmail.com,
tj@kernel.org
Subject: Re: [PATCH v2] mm/page-writeback: Update the comment of Dirty position control
Date: Tue, 11 May 2021 12:45:40 +0200 [thread overview]
Message-ID: <20210511104540.GJ24154@quack2.suse.cz> (raw)
In-Reply-To: <20210511103606.3732-1-wuchi.zero@gmail.com>
On Tue 11-05-21 18:36:06, Chi Wu wrote:
> As the value of pos_ratio_polynom() clamp between 0 and
> 2LL << RATELIMIT_CALC_SHIFT, the global control line should be
> consistent with it.
>
> Signed-off-by: Chi Wu <wuchi.zero@gmail.com>
Thanks! Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 0062d5c57d41..3882405dc051 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -845,7 +845,7 @@ static long long pos_ratio_polynom(unsigned long setpoint,
> * ^ pos_ratio
> * |
> * | |<===== global dirty control scope ======>|
> - * 2.0 .............*
> + * 2.0 * * * * * * *
> * | .*
> * | . *
> * | . *
> --
> 2.17.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2021-05-11 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 5:26 [PATCH] mm/page-writeback: Update the comment of Dirty position control Chi Wu
2021-05-11 9:06 ` Jan Kara
2021-05-11 10:01 ` chi wu
2021-05-11 10:36 ` [PATCH v2] " Chi Wu
2021-05-11 10:45 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511104540.GJ24154@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=hcochran@kernelspring.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mszeredi@redhat.com \
--cc=sedat.dilek@gmail.com \
--cc=tj@kernel.org \
--cc=wuchi.zero@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).