Re: [PATCH 1/3] kasan: use separate (un)poison implementation for integrated init

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4367 bytes --]

Hi Peter,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.13-rc1 next-20210511]
[cannot apply to hnaz-linux-mm/master arm64/for-next/core tip/perf/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Peter-Collingbourne/kasan-use-separate-un-poison-implementation-for-integrated-init/20210511-153308
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1140ab592e2ebf8153d2b322604031a8868ce7a5
config: powerpc64-randconfig-r033-20210511 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a0fed635fe1701470062495a6ffee1c608f3f1bc)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://github.com/0day-ci/linux/commit/4c25c2115c30074af7d702e9db8ba9d0d0b2c578
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Peter-Collingbourne/kasan-use-separate-un-poison-implementation-for-integrated-init/20210511-153308
        git checkout 4c25c2115c30074af7d702e9db8ba9d0d0b2c578
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> mm/mempool.c:110:8: error: too many arguments to function call, expected 2, have 3
                                      false);
                                      ^~~~~
   include/linux/kasan.h:314:20: note: 'kasan_poison_pages' declared here
   static inline void kasan_poison_pages(struct page *page, unsigned int order) {}
                      ^
   mm/mempool.c:119:10: error: too many arguments to function call, expected 2, have 3
                                        false);
                                        ^~~~~
   include/linux/kasan.h:315:20: note: 'kasan_unpoison_pages' declared here
   static inline void kasan_unpoison_pages(struct page *page, unsigned int order) {}
                      ^
   2 errors generated.
--
>> mm/page_alloc.c:1319:36: error: too many arguments to function call, expected 2, have 3
                           kasan_poison_pages(page, order, init);
                           ~~~~~~~~~~~~~~~~~~              ^~~~
   include/linux/kasan.h:314:20: note: 'kasan_poison_pages' declared here
   static inline void kasan_poison_pages(struct page *page, unsigned int order) {}
                      ^
   mm/page_alloc.c:2351:37: error: too many arguments to function call, expected 2, have 3
                   kasan_unpoison_pages(page, order, init);
                   ~~~~~~~~~~~~~~~~~~~~              ^~~~
   include/linux/kasan.h:315:20: note: 'kasan_unpoison_pages' declared here
   static inline void kasan_unpoison_pages(struct page *page, unsigned int order) {}
                      ^
   mm/page_alloc.c:3655:15: warning: no previous prototype for function 'should_fail_alloc_page' [-Wmissing-prototypes]
   noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
                 ^
   mm/page_alloc.c:3655:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
   noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
            ^
            static 
   1 warning and 2 errors generated.


vim +110 mm/mempool.c

   103	
   104	static __always_inline void kasan_poison_element(mempool_t *pool, void *element)
   105	{
   106		if (pool->alloc == mempool_alloc_slab || pool->alloc == mempool_kmalloc)
   107			kasan_slab_free_mempool(element);
   108		else if (pool->alloc == mempool_alloc_pages)
   109			kasan_poison_pages(element, (unsigned long)pool->pool_data,
 > 110					   false);
   111	}
   112	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30123 bytes --]