From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC487C433ED for ; Thu, 13 May 2021 12:10:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 61FFE611CC for ; Thu, 13 May 2021 12:10:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61FFE611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D53966B0036; Thu, 13 May 2021 08:10:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D29FF6B006E; Thu, 13 May 2021 08:10:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF1FE6B0070; Thu, 13 May 2021 08:10:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id 8DF256B0036 for ; Thu, 13 May 2021 08:10:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3069F98B9 for ; Thu, 13 May 2021 12:10:18 +0000 (UTC) X-FDA: 78136090116.27.8C78937 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf14.hostedemail.com (Postfix) with ESMTP id 4A71FC001C66 for ; Thu, 13 May 2021 12:09:52 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id h20so14264572plr.4 for ; Thu, 13 May 2021 05:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GIgBu0cXrDYQWIYcm6hEflFDTrhhfQxoWqqkLDTuF54=; b=TLQurYwVvXYBe2o3JZtkkCkLnNKAMQzVyefuAG+6gL2FsAYPukZR4VOUws5whXNTFn fyCHs5SWFj4cc/QekoElcQts7qqvLemYLDUK8EeVn0qSvRuo8vJjb5WsNISe0b3K8/VF z6bwwDN/qr2Jj3gkuHL0RCl2ZUKy/K2A5laCP3oKa5Y7EEWitjyFNFo1fmGP4YGoameR atklHBHkxxDE7Lk3tt3HMVqWjXBFexlKNbQzaRE3C31jmR0QqQTK1xpFPK20Fj52t3rh a/kkLVLJMTjclqshyETxUoCCu50gjaD7JC1ez5va8+Vah9B76DsBfP1suZNXF9xh+Z7/ 1Jrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GIgBu0cXrDYQWIYcm6hEflFDTrhhfQxoWqqkLDTuF54=; b=RTEAEdvTy8qUkUi3LOBoI8r+LpoMWzBqSUvSb3Vli1bC1LjeDzSDSFD255j9sxXxr7 d1CZ1kfOaHiDjEwHw78YTZo8pOdOaCh9j8ysQUTfoOwxxQ0liuOYIVwo5pEyXL2/Ra6F FnuezRzYUYLkOBb9KF1qimM1tGEvp0f2IVHKmROcArvFxmQYZsBd7UtcBPWKAgttxK12 pbn/qk6ZpW5ZBf7qW8iMBEWgxP3donYj4rK6nVpt6RXcJKaLx6benMOIgLxGpRcjeGIG PN422Hom1qOmShG/W2lM76C+Bxd8ZVToUJUh4UYFA3zA3lHNfFIZfKT1pDsYNw8PHKXT ZuwQ== X-Gm-Message-State: AOAM530OtGixNzyLTygNzAKPFhSO3EE4vkjS1jpfkP3zaUF2+GthHrIo MAB6SxbYsxiX5/cIjiDMS+A= X-Google-Smtp-Source: ABdhPJwYQ8Aobb4fgVUj6E1ey4GT5R/j+ptNIujUvEG4uu22ypl4B8h5z4i+Uphfkqm/fhRaTGVwLw== X-Received: by 2002:a17:902:d206:b029:ee:92d0:4405 with SMTP id t6-20020a170902d206b02900ee92d04405mr39040058ply.43.1620907816921; Thu, 13 May 2021 05:10:16 -0700 (PDT) Received: from hyeyoo ([121.135.181.35]) by smtp.gmail.com with ESMTPSA id t19sm2026073pfg.70.2021.05.13.05.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 05:10:16 -0700 (PDT) Date: Thu, 13 May 2021 21:10:11 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Marco Elver , Andrew Morton , iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time Message-ID: <20210513121011.GA774527@hyeyoo> References: <20210511173448.GA54466@hyeyoo> <20210512195227.245000695c9014242e9a00e5@linux-foundation.org> <20210513031220.GA133011@hyeyoo> <20210512204024.401ff3de38649d7d0f5a45e8@linux-foundation.org> <20210513062809.GA319973@hyeyoo> <90c1b2ae-a5c1-07d1-b056-5b3699b6cc77@suse.cz> <20210513120829.GB772931@hyeyoo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210513120829.GB772931@hyeyoo> X-Rspamd-Queue-Id: 4A71FC001C66 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=TLQurYwV; spf=pass (imf14.hostedemail.com: domain of 42hyeyoo@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=42hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: rkgcxis97tz5p1ne18og6e1ajx6ftdd8 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from="<42.hyeyoo@gmail.com>"; helo=mail-pl1-f180.google.com; client-ip=209.85.214.180 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620907792-165210 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 13, 2021 at 09:08:29PM +0900, Hyeonggon Yoo wrote: > I completely agree on what Vlastimil said. there should be comment > saying that generally you should not use kmalloc_index with > size_is_const == true. sorry there was human error. what I mean was: size_is_const == false