From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAD11C433ED for ; Sat, 15 May 2021 16:35:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 488AE61185 for ; Sat, 15 May 2021 16:35:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 488AE61185 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8607C6B00A0; Sat, 15 May 2021 12:35:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 811E46B00A2; Sat, 15 May 2021 12:35:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68B2B6B00A3; Sat, 15 May 2021 12:35:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 351976B00A0 for ; Sat, 15 May 2021 12:35:29 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C00B6AF9E for ; Sat, 15 May 2021 16:35:28 +0000 (UTC) X-FDA: 78144015936.27.30480B1 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf09.hostedemail.com (Postfix) with ESMTP id 0DDF96000108 for ; Sat, 15 May 2021 16:35:26 +0000 (UTC) Received: by mail-qt1-f181.google.com with SMTP id h21so1894500qtu.5 for ; Sat, 15 May 2021 09:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6rKLntZO/5o/apLZQWKMZB3LLHw2NcASFdCosdEebqk=; b=Y10XP7028Bj4GuwdZNSMPJrk432ozPJfeEL2CFeMvEglPxMYjvqwJeCRf6QLrLtIyd 85jD+EnfGKX9ltzNTP311imyU6L6StDDBetJK1o5uj5bdU2KA5lXX8OKrhM/DubsmI8R yaUwH7cxsxeX6SEPxYYz98UeBG+/72iNf+gUAOw2anc5gwUIO8IomC5PYa9JQdjkp3YM qzKbr3N33S8KaS+HVuz1EyLv97YY37kgaLh+OGyWd2t8hV/mgxMNStlgVzlrQ4wN+6cG yKorGYYcQaG0A2f0i8a6HVq7lb4x5+8zBE1U/0JeDw7oC1mIFqVrHtRAx+7sgFC7J+D4 /HAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=6rKLntZO/5o/apLZQWKMZB3LLHw2NcASFdCosdEebqk=; b=hmb/9UHNHWZIXcoV7pRFjr8tSYb8u4BYsvgqgo/6ijKtwTnQjbVZEERvfhlA26vMvr vvOLC358T/izCTVo3vNyXQeHWxNQNjCmK2uIV8Mu8cMhigK1ryadyDHyA0yRi5e41wLY mqpHJyLt6+YxqX510cmbizLjeTsU8P5CUSOsQXxg4J5X9yOXrLbJ6k5xV6lHUcCnCTOG vLTz/YmqJq5RMJLxus6qzpX8vO9KjpVtjjBftSALmRsB+1AWkxvUPNzQRpqVD96jQh1l akh1t1YY2oGkrbKZ01luabsXOD2iinhIb0bd0jYb244jaCbUoSCtvYBQX9IQJgH3tGgC fweA== X-Gm-Message-State: AOAM5326+7go6rec75MwXo1EyGrIwzOdh0ovtfa4OR9y/ga+TMfcSzMx KuY7y5/V1+3jAcd+lFPtgDM= X-Google-Smtp-Source: ABdhPJxG1LjipH9fLU+4E7UOxNVGIx4NgmwkDEqV22ni2orbdercqv/dxVNLyw9KmqrBYtc5BFZMvg== X-Received: by 2002:ac8:5553:: with SMTP id o19mr1755021qtr.308.1621096527754; Sat, 15 May 2021 09:35:27 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 7sm6981495qkd.20.2021.05.15.09.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 09:35:27 -0700 (PDT) Date: Sat, 15 May 2021 09:35:25 -0700 From: Guenter Roeck To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, kaleshsingh@google.com, npiggin@gmail.com, joel@joelfernandes.org, Christophe Leroy Subject: Re: [PATCH v5 5/9] powerpc/mm/book3s64: Update tlb flush routines to take a page walk cache flush argument Message-ID: <20210515163525.GA1106462@roeck-us.net> References: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> <20210422054323.150993-6-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422054323.150993-6-aneesh.kumar@linux.ibm.com> Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Y10XP702; dmarc=none; spf=pass (imf09.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=groeck7@gmail.com X-Stat-Signature: bspjfsf3x595n8988b7jqi19nkcyer7m X-Rspamd-Queue-Id: 0DDF96000108 X-Rspamd-Server: rspam02 X-HE-Tag: 1621096526-82110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 22, 2021 at 11:13:19AM +0530, Aneesh Kumar K.V wrote: > No functional change in this patch > > Signed-off-by: Aneesh Kumar K.V > --- > .../include/asm/book3s/64/tlbflush-radix.h | 19 +++++++----- > arch/powerpc/include/asm/book3s/64/tlbflush.h | 23 ++++++++++++--- > arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 4 +-- > arch/powerpc/mm/book3s64/radix_tlb.c | 29 +++++++------------ > 4 files changed, 42 insertions(+), 33 deletions(-) > > diff --git a/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h b/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h > index 8b33601cdb9d..171441a43b35 100644 > --- a/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h > +++ b/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h > @@ -56,15 +56,18 @@ static inline void radix__flush_all_lpid_guest(unsigned int lpid) > } > #endif > > -extern void radix__flush_hugetlb_tlb_range(struct vm_area_struct *vma, > - unsigned long start, unsigned long end); > -extern void radix__flush_tlb_range_psize(struct mm_struct *mm, unsigned long start, > - unsigned long end, int psize); > -extern void radix__flush_pmd_tlb_range(struct vm_area_struct *vma, > - unsigned long start, unsigned long end); > -extern void radix__flush_tlb_range(struct vm_area_struct *vma, unsigned long start, > +void radix__flush_hugetlb_tlb_range(struct vm_area_struct *vma, > + unsigned long start, unsigned long end, > + bool flush_pwc); > +void radix__flush_pmd_tlb_range(struct vm_area_struct *vma, > + unsigned long start, unsigned long end, > + bool flush_pwc); > +void radix__flush_tlb_pwc_range_psize(struct mm_struct *mm, unsigned long start, > + unsigned long end, int psize, bool flush_pwc); > +void radix__flush_tlb_range(struct vm_area_struct *vma, unsigned long start, > unsigned long end); > -extern void radix__flush_tlb_kernel_range(unsigned long start, unsigned long end); > +void radix__flush_tlb_kernel_range(unsigned long start, unsigned long end); > + > > extern void radix__local_flush_tlb_mm(struct mm_struct *mm); > extern void radix__local_flush_all_mm(struct mm_struct *mm); > diff --git a/arch/powerpc/include/asm/book3s/64/tlbflush.h b/arch/powerpc/include/asm/book3s/64/tlbflush.h > index 215973b4cb26..f9f8a3a264f7 100644 > --- a/arch/powerpc/include/asm/book3s/64/tlbflush.h > +++ b/arch/powerpc/include/asm/book3s/64/tlbflush.h > @@ -45,13 +45,30 @@ static inline void tlbiel_all_lpid(bool radix) > hash__tlbiel_all(TLB_INVAL_SCOPE_LPID); > } > > +static inline void flush_pmd_tlb_pwc_range(struct vm_area_struct *vma, ^^^^ > + unsigned long start, > + unsigned long end, > + bool flush_pwc) > +{ > + if (radix_enabled()) > + return radix__flush_pmd_tlb_range(vma, start, end, flush_pwc); > + return hash__flush_tlb_range(vma, start, end); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > +} > > #define __HAVE_ARCH_FLUSH_PMD_TLB_RANGE > static inline void flush_pmd_tlb_range(struct vm_area_struct *vma, ^^^^ > unsigned long start, unsigned long end) > +{ > + return flush_pmd_tlb_pwc_range(vma, start, end, false); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Doesn't that cause build warnings/errors all over the place ? Guenter