From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C39EDC433ED for ; Mon, 17 May 2021 12:59:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 477BC6124C for ; Mon, 17 May 2021 12:59:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 477BC6124C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB2D86B0036; Mon, 17 May 2021 08:59:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A62B36B006E; Mon, 17 May 2021 08:59:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DD316B0070; Mon, 17 May 2021 08:59:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 5B96C6B0036 for ; Mon, 17 May 2021 08:59:09 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DE39A62E8 for ; Mon, 17 May 2021 12:59:08 +0000 (UTC) X-FDA: 78150728376.29.D3FD882 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf24.hostedemail.com (Postfix) with ESMTP id A36FBA000399 for ; Mon, 17 May 2021 12:59:06 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 51850AEF5; Mon, 17 May 2021 12:59:07 +0000 (UTC) Date: Mon, 17 May 2021 14:59:03 +0200 From: Oscar Salvador To: Naoya Horiguchi Cc: Muchun Song , linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Michal Hocko , Tony Luck , Naoya Horiguchi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] mm,hwpoison: make get_hwpoison_page call get_any_page() Message-ID: <20210517125859.GA25228@linux> References: <20210517045401.2506032-1-nao.horiguchi@gmail.com> <20210517045401.2506032-3-nao.horiguchi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517045401.2506032-3-nao.horiguchi@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A36FBA000399 X-Stat-Signature: 1s78der718aih1dkxpwm9mb6g96zqz1n X-HE-Tag: 1621256346-547414 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 17, 2021 at 01:54:01PM +0900, Naoya Horiguchi wrote: > static int __get_hwpoison_page(struct page *page) > { > struct page *head = compound_head(page); > @@ -1098,7 +1091,9 @@ static int __get_hwpoison_page(struct page *page) > > #ifdef CONFIG_HUGETLB_PAGE > spin_lock(&hugetlb_lock); > - if (PageHuge(head) && (HPageFreed(head) || HPageMigratable(head))) > + if (!PageHuge(head)) > + ret = -EBUSY; Unless I'm missing something, we will be returning -EBUSY for any non-hugetlb page, which is not right. I think what you want is to return -EBUSY in case the page is a hugetlb page but we cannot grab a refcount because the page is in a floating state, meaning !HPageFreed && !HPageMigratable. Right? -- Oscar Salvador SUSE L3