From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F55C43618 for ; Mon, 17 May 2021 15:09:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D08AE61355 for ; Mon, 17 May 2021 15:09:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D08AE61355 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 31A2A6B006C; Mon, 17 May 2021 11:09:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CAD96B006E; Mon, 17 May 2021 11:09:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16AAB6B0070; Mon, 17 May 2021 11:09:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id D80D76B006C for ; Mon, 17 May 2021 11:09:29 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7C3B8A748 for ; Mon, 17 May 2021 15:09:29 +0000 (UTC) X-FDA: 78151056858.08.80B4BE0 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf02.hostedemail.com (Postfix) with ESMTP id 2C0CE40002EE for ; Mon, 17 May 2021 15:09:27 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9B470AEBB; Mon, 17 May 2021 15:09:27 +0000 (UTC) Date: Mon, 17 May 2021 16:09:22 +0100 From: Mel Gorman To: Yang Shi Cc: kirill.shutemov@linux.intel.com, ziy@nvidia.com, mhocko@suse.com, ying.huang@intel.com, hughd@google.com, gerald.schaefer@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH 1/7] mm: memory: add orig_pmd to struct vm_fault Message-ID: <20210517150922.GU3672@suse.de> References: <20210413212416.3273-1-shy828301@gmail.com> <20210413212416.3273-2-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210413212416.3273-2-shy828301@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=mgorman@suse.de X-Stat-Signature: hdmgo19sxib7wwebogckbhea7hu6ar1d X-Rspamd-Queue-Id: 2C0CE40002EE X-Rspamd-Server: rspam02 X-HE-Tag: 1621264167-474156 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 13, 2021 at 02:24:10PM -0700, Yang Shi wrote: > Add orig_pmd to struct vm_fault so the "orig_pmd" parameter used by huge page > fault could be removed, just like its PTE counterpart does. > > Signed-off-by: Yang Shi > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 25b9041f9925..9c5856f8cc81 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -547,6 +547,9 @@ struct vm_fault { > * the 'address' > */ > pte_t orig_pte; /* Value of PTE at the time of fault */ > + pmd_t orig_pmd; /* Value of PMD at the time of fault, > + * used by PMD fault only. > + */ > > struct page *cow_page; /* Page handler may use for COW fault */ > struct page *page; /* ->fault handlers should return a Could this be a union? -- Mel Gorman SUSE Labs