From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A56C433ED for ; Tue, 18 May 2021 11:18:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D50D610FA for ; Tue, 18 May 2021 11:18:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D50D610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C9CA16B00D1; Tue, 18 May 2021 07:18:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C73C96B00D3; Tue, 18 May 2021 07:18:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEE266B00D4; Tue, 18 May 2021 07:18:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 7AD3A6B00D1 for ; Tue, 18 May 2021 07:18:24 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1132918037D4D for ; Tue, 18 May 2021 11:18:24 +0000 (UTC) X-FDA: 78154103328.37.E55DD6D Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf28.hostedemail.com (Postfix) with ESMTP id 42B0B200024F for ; Tue, 18 May 2021 11:18:22 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id t4so4901905plc.6 for ; Tue, 18 May 2021 04:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dZZVNFLqfyQH+VZvfCK9B+B15hMckx1kank4ZW1zXaA=; b=tUjRjX1ydb8TkYHy1prhwcsPIdQL4leqUgTWWihQ1h+gVvR35d/SI1dcgqGeUqCPvF VHhueAeFnuyn70zb9n057oEGJPcwTa24APthSUiuj6QOTZI1ORAOanesGyPcSGXu5JZX mUEV8LOEIWq3EZpZTWDN1B/rRWHkAvw+9ClXzJ/jZL5RFdwGUivxLEaEfIE/mK3BTqOX PF1LRB3jvZOErP/ptquNNnVjxYhIvbwjpgh7pehjzYIlpBbmyigFHyQ9aQEpptgNGy5Y 3PsDwDPkmNx92dcf5gl3sxzDKvl32VZoiy0m3bEQIAhNFC12Gc/7rJ+362HDcflshxNr bJ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dZZVNFLqfyQH+VZvfCK9B+B15hMckx1kank4ZW1zXaA=; b=uH/JA/NmdbY+fQPJDeuqfrcnjI2AMLIRHyE8gD7RZA3RkeT/1VmtotXd6bRKu28DqL t3YeNDCHzgJQHXFC8zMBkQRqzyq9tSLd4qGH/BbpU4v4OFnrcolH+JegHQvOwTTAwFgB 26XvoMzyaAynnb8mxwe7DHuGnC7SN9vHJfBOyAYWeYzLh6+y8Z2AEE4U+GJxQnIU5S/x YF3QVvoH81wt8k8lEmxEqk6VswRto1BxOOOF9Gvm6/eSbk0KO3TqB6bQH7Aw85cH+86/ YFOOm7Z6hMLAay8yfC3qPVnjLpG7RmelskkRBRQh0jNBxVufE8v1GRC+B5KmqHooZLOX ltrw== X-Gm-Message-State: AOAM533Jbw6od7WYY6XwQDHkaMNNmlvPO04KrblCiStiqlY0t+Uyzr27 aLNlwE+ZZXjlQy3krnvc2Vg= X-Google-Smtp-Source: ABdhPJwLcUthcBK/v5oa5CbZQetVtricm0UyXz/sKyw0jhrq621ppUQ4prxNkNeqd2pbaMVn2+qrnQ== X-Received: by 2002:a17:90b:1949:: with SMTP id nk9mr4452592pjb.220.1621336702633; Tue, 18 May 2021 04:18:22 -0700 (PDT) Received: from hyeyoo ([121.135.181.35]) by smtp.gmail.com with ESMTPSA id j16sm3516074pfi.92.2021.05.18.04.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 04:18:22 -0700 (PDT) Date: Tue, 18 May 2021 20:18:14 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Nathan Chancellor , akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org, clang-built-linux@googlegroups.com, linux-next@vger.kernel.org, ndesaulniers@google.com, lkft-triage@lists.linaro.org, sfr@canb.auug.org.au, arnd@arndb.de, Marco Elver Subject: Re: [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time Message-ID: <20210518111814.GA114501@hyeyoo> References: <20210511173448.GA54466@hyeyoo> <20210515210950.GA52841@hyeyoo> <41c65455-a35b-3ad3-54f9-49ca7105bfa9@suse.cz> <20210518003859.GC80297@hyeyoo> <71416382-2e4c-5e03-df9c-265fda41c2de@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71416382-2e4c-5e03-df9c-265fda41c2de@suse.cz> Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=tUjRjX1y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of 42hyeyoo@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=42hyeyoo@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 42B0B200024F X-Stat-Signature: kcsik8s6tjueohqj4fgdnktrbxkxbket X-HE-Tag: 1621336702-248588 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 11:28:17AM +0200, Vlastimil Babka wrote: > On 5/18/21 2:43 AM, Nathan Chancellor wrote: > > On 5/17/2021 5:38 PM, Hyeonggon Yoo wrote: > >> On Sat, May 15, 2021 at 11:34:49PM -0700, Nathan Chancellor wrote: > >>> This should work I think: > >> > >> compiled well with clang-10.0.1, clang-11.0.0, > >> and gcc-10.2.0 with x86_64 default config. > >> > >> is the condition CONFIG_CLANG_VERSION > 110000, > >> not including 110000 it self? > > Good spot. Thanks! > > Ah sorry, that should definitely be >= :( > > > > That is what I get for writing an email that late... in reality, it probably > > won't matter due to the availability of 11.0.1 and 11.1.0 but it should > > absolutely be changed. > > > > I have not given Nick's patch a go yet but would something like this be > > acceptable? > > Yes. You mean Nick's patch to added with Nathan's code? I'm not sure we need this, but will add it if you can accept it. I'll send fixup patch soon. tell me if I can improve anything on it. Thanks, Hyeonggon