From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67D4C4707F for ; Tue, 25 May 2021 07:36:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 56FEE613F5 for ; Tue, 25 May 2021 07:36:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56FEE613F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C9DA26B006C; Tue, 25 May 2021 03:36:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4C8B6B006E; Tue, 25 May 2021 03:36:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEDD26B0070; Tue, 25 May 2021 03:36:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 7E7DE6B006C for ; Tue, 25 May 2021 03:36:10 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 13F7E8798 for ; Tue, 25 May 2021 07:36:10 +0000 (UTC) X-FDA: 78178944900.12.87C68B0 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf01.hostedemail.com (Postfix) with ESMTP id 8E7E85001537 for ; Tue, 25 May 2021 07:36:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621928168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9GKSyZSfAzVVq/ABR755e8Z5pcs9qhohd3YV/i12YGw=; b=Ets6WZ9YpTAvqq0ts49H1xJxPreCOpST9tTB/7sbHHhNZ424zNR6YJQZ9RCdidUReKkiYO lQBUIiq4cyuztVT/npnNNGCkNEYZ/NdkyTstGowh9N4za3CORvckFY+WPc495xGloLJp2H D4PbSA4WmMBbFY3CDaj14j45qFpn6Ts= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621928168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9GKSyZSfAzVVq/ABR755e8Z5pcs9qhohd3YV/i12YGw=; b=aeKZOMiCUet47hEHrHbJHkL4ltgc2DqW9DLkrsIl/zsZ/7FjFfxJX2m9YvmF8xwYEsld9u zc72a02lfs1kQ1Cg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4FB9CAE99; Tue, 25 May 2021 07:36:08 +0000 (UTC) Date: Tue, 25 May 2021 09:36:05 +0200 From: Oscar Salvador To: HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+j44CA55u05LmfKQ==?= Cc: Mike Kravetz , Naoya Horiguchi , Muchun Song , "linux-mm@kvack.org" , Andrew Morton , Michal Hocko , Tony Luck , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 1/2] mm,hwpoison: fix race with hugetlb page allocation Message-ID: <20210525073559.GA844@linux> References: <20210518231259.2553203-1-nao.horiguchi@gmail.com> <20210518231259.2553203-2-nao.horiguchi@gmail.com> <20210520071717.GA2641190@hori.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210520071717.GA2641190@hori.linux.bs1.fc.nec.co.jp> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Ets6WZ9Y; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aeKZOMiC; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8E7E85001537 X-Stat-Signature: gyn7sdq889zkdfz9qwfakdd5mgdg9q8q X-HE-Tag: 1621928163-257 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 20, 2021 at 07:17:17AM +0000, HORIGUCHI NAOYA(=E5=A0=80=E5=8F= =A3 =E7=9B=B4=E4=B9=9F) wrote: > So I think of inserting the check to comply with the assumption of > get_hwpoison_huge_page() like below: >=20 > ret =3D get_hwpoison_huge_page(head, &hugetlb); > if (hugetlb) > return ret; >=20 > if (!PageLRU(head) && !__PageMovable(head)) > return 0; >=20 > if (PageTransHuge(head)) { > ... > } >=20 > if (get_page_unless_zero(head)) { > ... > } >=20 > return 0; Hi Naoya, would you mind posting a complete draft of what it would look like? I am having a hard time picturing it. Thanks --=20 Oscar Salvador SUSE L3