linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org, Petr Mladek <pmladek@suse.com>,
	Joe Perches <joe@perches.com>
Subject: [PATCH v2 0/4] slub: Print non-hashed pointers in slub debugging
Date: Tue, 25 May 2021 19:56:21 -0700	[thread overview]
Message-ID: <20210526025625.601023-1-swboyd@chromium.org> (raw)

I was doing some debugging recently and noticed that my pointers were
being hashed while slub_debug was on the kernel commandline. Let's force
on the no hash pointer option when slub_debug is on the kernel
commandline so that the prints are more meaningful.

The first two patches are something else I noticed while looking at the
code. The message argument is never used so the debugging messages are
not as clear as they could be and the slub_debug=- behavior seems to be
busted. Then there's a printf fixup from Joe and the final patch is the
one that force disables pointer hashing.

Changes from v1
 * Dropped the hexdump printing format
 * Forced on the no_hash_pointers option instead of pushing %px

Joe Perches (1):
  slub: Indicate slab_fix() uses printf formats

Stephen Boyd (3):
  slub: Restore slub_debug=- behavior
  slub: Actually use 'message' in restore_bytes()
  slub: Force on no_hash_pointers when slub_debug is enabled

 lib/vsprintf.c |  2 +-
 mm/slub.c      | 15 ++++++++++++---
 2 files changed, 13 insertions(+), 4 deletions(-)


base-commit: d07f6ca923ea0927a1024dfccafc5b53b61cfecc
-- 
https://chromeos.dev



             reply	other threads:[~2021-05-26  2:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  2:56 Stephen Boyd [this message]
2021-05-26  2:56 ` [PATCH v2 1/4] slub: Restore slub_debug=- behavior Stephen Boyd
2021-05-26  4:04   ` [External] " Muchun Song
2021-05-26 10:39     ` Vlastimil Babka
2021-05-26 20:20       ` Stephen Boyd
2021-05-27  2:51         ` Muchun Song
2021-05-26  2:56 ` [PATCH v2 2/4] slub: Actually use 'message' in restore_bytes() Stephen Boyd
2021-05-26  3:29   ` [External] " Muchun Song
2021-05-26  2:56 ` [PATCH v2 3/4] slub: Indicate slab_fix() uses printf formats Stephen Boyd
2021-05-26 10:40   ` Vlastimil Babka
2021-05-26  2:56 ` [PATCH v2 4/4] slub: Force on no_hash_pointers when slub_debug is enabled Stephen Boyd
2021-05-26  5:40   ` kernel test robot
2021-05-26  7:54   ` kernel test robot
2021-05-26 10:48   ` Vlastimil Babka
2021-05-26 13:47     ` Petr Mladek
2021-05-26 19:27       ` Stephen Boyd
2021-05-31  9:28         ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526025625.601023-1-swboyd@chromium.org \
    --to=swboyd@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=pmladek@suse.com \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).