From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C6FEC47080 for ; Tue, 1 Jun 2021 07:48:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D07F5613A9 for ; Tue, 1 Jun 2021 07:48:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D07F5613A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2C9AE8D0003; Tue, 1 Jun 2021 03:48:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2798E8D0002; Tue, 1 Jun 2021 03:48:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11A588D0003; Tue, 1 Jun 2021 03:48:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D129D8D0002 for ; Tue, 1 Jun 2021 03:48:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5EF66180AD804 for ; Tue, 1 Jun 2021 07:48:49 +0000 (UTC) X-FDA: 78204378378.28.EFA9577 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf09.hostedemail.com (Postfix) with ESMTP id E7F326000562 for ; Tue, 1 Jun 2021 07:48:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622533727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S9prk+2gwg2DZFavGRu09bQUFIZZIRW16iZ1cNuKSr4=; b=ZiKgNokIHsd2SnNYzqrpV6TxHGII3qERvnMqIINa4nMAJ7YWTa5EhUBLnAG+7aVhV7a0vd nP63F6W22I7eJfw5eh3prmEUwrBjSqUJI+O4iqE5loR10QkHWZPXl2EuzV3kq8iAxYh/DQ 4B15drJPxBAAY7QlfTxB8laviBamoyU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622533727; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S9prk+2gwg2DZFavGRu09bQUFIZZIRW16iZ1cNuKSr4=; b=0/zCAiALno2JRWox5YV1ysf6J4DxEPeRuOD1yLnQhQpMv36XxXWgTpiNOq4cD3zwrjlw+/ fy/ZRJpAwBrZ86AA== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B10CDAB6D; Tue, 1 Jun 2021 07:48:47 +0000 (UTC) Date: Tue, 1 Jun 2021 08:48:45 +0100 From: Mel Gorman To: Andrew Morton Cc: kernel test robot , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Yang Shi Subject: Re: [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS' Message-ID: <20210601074845.GO3672@suse.de> References: <202105301909.iEwOXNWt-lkp@intel.com> <20210531093917.GL3672@suse.de> <20210531150554.bb7769cdedb4fd9bf471b891@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210531150554.bb7769cdedb4fd9bf471b891@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZiKgNokI; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="0/zCAiAL"; dmarc=none; spf=pass (imf09.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=mgorman@suse.de X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E7F326000562 X-Stat-Signature: ts16hh7t3eqfqaqhchmfrteithqpujs8 X-HE-Tag: 1622533721-619437 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 31, 2021 at 03:05:54PM -0700, Andrew Morton wrote: > On Mon, 31 May 2021 10:39:17 +0100 Mel Gorman wrote: > > > On Sun, May 30, 2021 at 07:58:14PM +0800, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > head: 3e029760e6f8ce90c122c267a039ae73b3f1f5a4 > > > commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust > > > config: x86_64-randconfig-a006-20210530 (attached as .config) > > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9) > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # install x86_64 cross compiling tool for clang build > > > # apt-get install binutils-x86-64-linux-gnu > > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c > > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > > git fetch --no-tags linux-next master > > > git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > > > > > > Hi Andrew, > > > > Can you please drop the patch > > mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust.patch? > > Didn't I fix this with > mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix.patch? > > This fix is lame - x86's fixmap.h should be standalone. But this gets us > moving ahead with the MM changes for now. > I think you did fix it but I was surprised by the level of fallout from this patch and then there were objections to adding header dependencies unnecessarily such as this https://lore.kernel.org/lkml/YK3vrIB7cWop+UIW@gmail.com/ . That was specific to modifying the x86 headers so your fix should not hit the same objection but still, as you said, x86 fixmap should be standalone. -- Mel Gorman SUSE Labs