From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89635C4708F for ; Tue, 1 Jun 2021 10:08:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B05961370 for ; Tue, 1 Jun 2021 10:08:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B05961370 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9CCFA6B00AE; Tue, 1 Jun 2021 06:08:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A3B26B00B0; Tue, 1 Jun 2021 06:08:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86B4D6B00B1; Tue, 1 Jun 2021 06:08:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 550E86B00AE for ; Tue, 1 Jun 2021 06:08:53 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id ED890A8C3 for ; Tue, 1 Jun 2021 10:08:52 +0000 (UTC) X-FDA: 78204731304.34.3A46700 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id 3CB2450904B4 for ; Tue, 1 Jun 2021 10:08:40 +0000 (UTC) Received: from relay2.suse.de (unknown [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 306761FD2D; Tue, 1 Jun 2021 10:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622542131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k20dQdDrZBQgdj1Stp+JsXCNuIAKAaJIRdQZLUfTaAo=; b=Bu6hV+SeLHNwiCFRzZ7zKG26Zb0NRoFtZhLV1AiOsEMgkZxZYjyg1oOTNIoxzE/XjJA+NQ 2Wf7h6snU8rYo7QS45aiMHbRT/2QsyZECrbPis//NbHcs/gsjqloT4R9t+KnPB8ZZ7O6ry FBs9PqrxkLpxRpyPnmqDi8yUbe7FCiM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622542131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k20dQdDrZBQgdj1Stp+JsXCNuIAKAaJIRdQZLUfTaAo=; b=9dm/f41xQT3PueXGRTr+xM3bqSRlwZfCVWcjS5Lt6Z37VnybA+4DF7LPuGrdACo4U8D8p9 yqr58su+MEkx7dBg== Received: from suse.de (unknown [10.163.43.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C9700A3B87; Tue, 1 Jun 2021 10:08:50 +0000 (UTC) Date: Tue, 1 Jun 2021 11:08:49 +0100 From: Mel Gorman To: Dan Carpenter Cc: Andrew Morton , Yang Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm: thp: fix a double unlock bug Message-ID: <20210601100849.GQ3672@suse.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 3CB2450904B4 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Bu6hV+Se; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="9dm/f41x"; dmarc=none; spf=pass (imf01.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=mgorman@suse.de X-Rspamd-Server: rspam03 X-Stat-Signature: f8iu9sqdzbi4zaz5uzpp5fw5eixoedsd X-HE-Tag: 1622542120-446860 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 01, 2021 at 12:24:09PM +0300, Dan Carpenter wrote: > We're supposed to be holding the "vmf->ptl" spin_lock when we goto > out_map. The lock is dropped after if finishes cleaning up. > > Fixes: 9aff7b33c74a ("mm: thp: refactor NUMA fault handling") > Signed-off-by: Dan Carpenter Ouch. Acked-by: Mel Gorman However, that git commit is not stable. Instead of Fixes: I would suggest renaming the patch to "mm: thp: refactor NUMA fault handling -fix" and replacing Fixes with "This patch is a fix to the mmotm patch mm-thp-refactor-numa-fault-handling.patch". Andrew usually slots that into the correct place in his quilt series and collapses the fixes before sending to Linus which works better with bisection. -- Mel Gorman SUSE Labs