From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, Petr Mladek <pmladek@suse.com>,
Joe Perches <joe@perches.com>
Subject: [PATCH v3 0/4] slub: Print non-hashed pointers in slub debugging
Date: Tue, 1 Jun 2021 11:21:58 -0700 [thread overview]
Message-ID: <20210601182202.3011020-1-swboyd@chromium.org> (raw)
I was doing some debugging recently and noticed that my pointers were
being hashed while slub_debug was on the kernel commandline. Let's force
on the no hash pointer option when slub_debug is on the kernel
commandline so that the prints are more meaningful.
The first two patches are something else I noticed while looking at the
code. The message argument is never used so the debugging messages are
not as clear as they could be and the slub_debug=- behavior seems to be
busted. Then there's a printf fixup from Joe and the final patch is the
one that force disables pointer hashing.
Changes from v2 (https://lore.kernel.org/r/20210526025625.601023-1-swboyd@chromium.org):
* Fixed up Fixes tag on first first patch
* Picked up acks
* Moved decl of no_hash_pointers() to kernel.h
Changes from v1:
* Dropped the hexdump printing format
* Forced on the no_hash_pointers option instead of pushing %px
Joe Perches (1):
slub: Indicate slab_fix() uses printf formats
Stephen Boyd (3):
slub: Restore slub_debug=- behavior
slub: Actually use 'message' in restore_bytes()
slub: Force on no_hash_pointers when slub_debug is enabled
include/linux/kernel.h | 2 ++
lib/vsprintf.c | 2 +-
mm/slub.c | 13 ++++++++++---
3 files changed, 13 insertions(+), 4 deletions(-)
base-commit: d07f6ca923ea0927a1024dfccafc5b53b61cfecc
--
https://chromeos.dev
next reply other threads:[~2021-06-01 18:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 18:21 Stephen Boyd [this message]
2021-06-01 18:21 ` [PATCH v3 1/4] slub: Restore slub_debug=- behavior Stephen Boyd
2021-06-01 18:22 ` [PATCH v3 2/4] slub: Actually use 'message' in restore_bytes() Stephen Boyd
2021-06-01 18:22 ` [PATCH v3 3/4] slub: Indicate slab_fix() uses printf formats Stephen Boyd
2021-06-06 0:06 ` David Rientjes
2021-06-01 18:22 ` [PATCH v3 4/4] slub: Force on no_hash_pointers when slub_debug is enabled Stephen Boyd
2021-06-01 22:45 ` kernel test robot
2021-06-02 0:26 ` Andrew Morton
2021-06-02 1:03 ` Stephen Boyd
2021-06-02 10:48 ` Vlastimil Babka
2021-06-02 10:50 ` Vlastimil Babka
2021-06-03 13:15 ` Petr Mladek
2021-09-20 14:29 ` Kees Cook
2021-09-20 18:23 ` Stephen Boyd
2021-09-20 18:28 ` Kees Cook
2021-09-20 18:44 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601182202.3011020-1-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).