From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE2CC47094 for ; Tue, 8 Jun 2021 00:26:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4AFC86124B for ; Tue, 8 Jun 2021 00:26:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AFC86124B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 992EC6B0036; Mon, 7 Jun 2021 20:26:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91C4D6B006E; Mon, 7 Jun 2021 20:26:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 794D76B0070; Mon, 7 Jun 2021 20:26:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 41BDE6B0036 for ; Mon, 7 Jun 2021 20:26:11 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D38C2180AD804 for ; Tue, 8 Jun 2021 00:26:10 +0000 (UTC) X-FDA: 78228664500.38.3E3C556 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf01.hostedemail.com (Postfix) with ESMTP id 83C7A5001533 for ; Tue, 8 Jun 2021 00:26:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4310A61108; Tue, 8 Jun 2021 00:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1623111969; bh=snPAZuAOgkkqsG4GmRCwE8HGSlQHlrj0xdKmSFqf1Vs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Hvel4w0ED4cnDiJjzmuiFmSk4D0EmI/3vNYCKsPRXAUeS9vwnJ5kf6GGUqSoK2EBn Lz+xbCQ4kVxBXEbKT7yh+gAiyjrNTVjN513vQws8Au51m76VK93nmsvG9C9r87xZuS AZA5ikXn9aYPiH/elXlzpp+17+gsWkaQMAJdt26Q= Date: Mon, 7 Jun 2021 17:26:08 -0700 From: Andrew Morton To: Kefeng Wang Cc: , , "Thomas Gleixner" , Ingo Molnar , Subject: Re: [PATCH v2 15/15] x86: convert to setup_initial_init_mm() Message-Id: <20210607172608.fda6ee76f9b195428ddb1d0d@linux-foundation.org> In-Reply-To: <20210604070633.32363-16-wangkefeng.wang@huawei.com> References: <20210604070633.32363-1-wangkefeng.wang@huawei.com> <20210604070633.32363-16-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Hvel4w0E; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: q9gh3zurfh9du4fchtxc8u9sbsmkrece X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 83C7A5001533 X-HE-Tag: 1623111967-401549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 4 Jun 2021 15:06:33 +0800 Kefeng Wang wrote: > Use setup_initial_init_mm() helper to simplify code. > > ... > > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -868,10 +868,7 @@ void __init setup_arch(char **cmdline_p) > > if (!boot_params.hdr.root_flags) > root_mountflags &= ~MS_RDONLY; > - init_mm.start_code = (unsigned long) _text; > - init_mm.end_code = (unsigned long) _etext; > - init_mm.end_data = (unsigned long) _edata; > - init_mm.brk = _brk_end; > + setup_initial_init_mm(_text, _etext, _edata, _brk_end); > > code_resource.start = __pa_symbol(_text); > code_resource.end = __pa_symbol(_etext)-1; arch/x86/kernel/setup.c:873:47: warning: passing argument 4 of 'setup_initial_init_mm' makes pointer from integer without a cast [-Wint-conversion] 873 | setup_initial_init_mm(_text, _etext, _edata, _brk_end); | ^~~~~~~~ | | | long unsigned int In file included from ./include/linux/pid_namespace.h:7, from ./include/linux/ptrace.h:10, from ./include/linux/elfcore.h:11, from ./include/linux/crash_core.h:6, from ./include/linux/kexec.h:18, from ./include/linux/crash_dump.h:5, from arch/x86/kernel/setup.c:9: ./include/linux/mm.h:248:29: note: expected 'void *' but argument is of type 'long unsigned int' 248 | void *end_data, void *brk); | ~~~~~~^~~ afaict the other architectures will warn this way, not sure. Please check all that, refresh ,retest and resend?