From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07947C47094 for ; Thu, 10 Jun 2021 09:15:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8AE5C613F5 for ; Thu, 10 Jun 2021 09:15:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AE5C613F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E9A86B0036; Thu, 10 Jun 2021 05:15:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19AB26B006E; Thu, 10 Jun 2021 05:15:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2F0E6B0071; Thu, 10 Jun 2021 05:15:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id C2AC86B0036 for ; Thu, 10 Jun 2021 05:15:55 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5F7E28249980 for ; Thu, 10 Jun 2021 09:15:55 +0000 (UTC) X-FDA: 78237257070.30.7D8C433 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf11.hostedemail.com (Postfix) with ESMTP id A38B42001060 for ; Thu, 10 Jun 2021 09:15:49 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id m21so2062980lfg.13 for ; Thu, 10 Jun 2021 02:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Wr6ozHJ9YAn6tkwbAWHJClxhdOSxSeF3/ANQDt15IBg=; b=Ao9890MUAJW99696YdIBhyJgMld3AjAdkz2sm77UQpWPt/xd6TroiC2wAeeEpkCN9c NRfDglQ27QpEecaeYFvFbtV7QKzpNSzcOKsWWh8pUnLHGDzc59U1VPYSFR95EURJHqb/ +W+b7KfaRK5s7p386x7pkQiwgwVifh7cJ67EHY6QgzeCH2vzmoiLEs12HPfFICALeZU8 8Tf3kaOZEoPpKRnQb965vGDtnmXfy0dDnqfVXNbXHyYbGh+JcqOSv3ZhzLsnRgGuAkkx PFVc53sdfb97LVU5AKdcF7DTrtEXpweTYjzV9nXr9TUxm4aKMquoIbo0VE/PuRDW0vp9 FYLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Wr6ozHJ9YAn6tkwbAWHJClxhdOSxSeF3/ANQDt15IBg=; b=l6WDOHvpvfKKp+rHKr3gdEIhwpjhUigJ7/H6y8i/U62GrqsYe29JUaK/RTkAxMkTFK tCF8gYrF8RGvSD7TBpW93N+S0r1yO9du/vfxgNBb9rAVq4IA1dpyQxAQkkpuXwdPTXoq xV+V9jD7WsIBHRLNGgBk6i+m/D1iilVsWq9liyzdF1JiiU4RhHNMPmMVlp3cx+FeqAqy 4xESgrUY8dpNL8cfagkWeA70PnlEqxSDjjwSJpzM1qB7smI8mGf5634qWjsXbeBZo1ZK zqt8Ykr3qQIB1IV0HfgxExgo6AbubCw9b+EogAbuWUB+oXgY+mnF3gPJCl29ZAB2pqy6 mJ1w== X-Gm-Message-State: AOAM532evgJ62Hz7QH+SWOCgbRWZRRmfSL+FlgbfZQ2HdElHjOg0VKOJ x1zbr5o7+dX/489ueQt02Uuyz3++H2jfew== X-Google-Smtp-Source: ABdhPJzsehUhEYCARVTWGNQmP9i7wfjK8FXXFnxNeAKNeJMryusJRqsLqX0ucwKHroZDe4khiBzUaw== X-Received: by 2002:a19:2d0f:: with SMTP id k15mr1365708lfj.237.1623316553716; Thu, 10 Jun 2021 02:15:53 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id g15sm242114lfu.55.2021.06.10.02.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 02:15:53 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 11CC61027EE; Thu, 10 Jun 2021 12:16:09 +0300 (+03) Date: Thu, 10 Jun 2021 12:16:09 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Alistair Popple , Ralph Campbell , Zi Yan , Peter Xu , Will Deacon , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/11] mm: page_vma_mapped_walk(): prettify PVMW_MIGRATION block Message-ID: <20210610091609.64kddqad5dfm2qrs@box.shutemov.name> References: <589b358c-febc-c88e-d4c2-7834b37fa7bf@google.com> <378c8650-1488-2edf-9647-32a53cf2e21@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <378c8650-1488-2edf-9647-32a53cf2e21@google.com> Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=Ao9890MU; dmarc=none; spf=none (imf11.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.41) smtp.mailfrom=kirill@shutemov.name X-Rspamd-Server: rspam02 X-Stat-Signature: n7j4k8z3wcnb6rpq84kri1znk6h8g4gx X-Rspamd-Queue-Id: A38B42001060 X-HE-Tag: 1623316549-723496 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 09, 2021 at 11:42:12PM -0700, Hugh Dickins wrote: > page_vma_mapped_walk() cleanup: rearrange the !pmd_present() block to > follow the same "return not_found, return not_found, return true" pattern > as the block above it (note: returning not_found there is never premature, > since existence or prior existence of huge pmd guarantees good alignment). > > Signed-off-by: Hugh Dickins > Cc: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov